Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Jenkinsfile to GH Actions Workflow #28

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Dec 20, 2022

Summary

Migrate Jenkinsfile to GH Actions Workflow

Details

Add docker layer caching to avoid docker pull rate limit.

Tasks

  • Migrate Jenkinsfile
  • Delete Jenkins Job config
  • Delete Jenkins Job
  • Update sheet

Depends On:

@reakaleek reakaleek marked this pull request as draft December 20, 2022 14:46
@reakaleek reakaleek force-pushed the feature/migrate-jenkinsfile-to-gh-actions-workflow branch from 88ff4b2 to 5b048a4 Compare December 20, 2022 15:31
@elastic elastic deleted a comment from apmmachine Dec 20, 2022
@reakaleek reakaleek requested a review from a team December 20, 2022 15:31
@reakaleek reakaleek marked this pull request as ready for review December 20, 2022 15:32
@reakaleek reakaleek requested review from bmorelli25 and removed request for bmorelli25 December 20, 2022 15:36
@elastic elastic deleted a comment from apmmachine Dec 20, 2022
@apmmachine
Copy link

❕ Build Aborted

There is a new build on-going so the previous on-going builds have been aborted.

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-20T15:27:28.245+0000

  • Duration: 12 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 144
Skipped 0
Total 144

Steps errors 1

Expand to view the steps failures

Checks if running on a Unix-like node
  • Took 0 min 0 sec . View more details here

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

.github/workflows/test.yml Outdated Show resolved Hide resolved
Copy link

@amannocci amannocci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reakaleek reakaleek marked this pull request as draft December 21, 2022 09:58
@reakaleek reakaleek force-pushed the feature/migrate-jenkinsfile-to-gh-actions-workflow branch from a535b4c to c30f8f0 Compare December 21, 2022 13:51
@reakaleek reakaleek marked this pull request as ready for review December 21, 2022 13:51
.github/workflows/test.yml Outdated Show resolved Hide resolved
@kuisathaverat kuisathaverat added the Team:Automation Label for the Observability productivity team label Dec 22, 2022
@kuisathaverat kuisathaverat requested a review from a team December 22, 2022 10:12
@reakaleek reakaleek force-pushed the feature/migrate-jenkinsfile-to-gh-actions-workflow branch from b30fb57 to 7332c80 Compare December 22, 2022 13:44
@reakaleek reakaleek force-pushed the feature/migrate-jenkinsfile-to-gh-actions-workflow branch from e0a281f to b115db9 Compare December 27, 2022 19:32
@reakaleek
Copy link
Member Author

reakaleek commented Dec 27, 2022

FYI

I had to change the command gem update --system in the Dockerfile (b115db9).
The solution was taken from rubygems/rubygems#2534 (comment). Otherwise, all the tests with docker images <=ruby:2.5 would fail while trying to update with the error:

ERROR:  Error installing rubygems-update:
	There are no versions of rubygems-update (= 3.4.1) compatible with your Ruby & RubyGems
	rubygems-update requires Ruby version >= 2.6.0. The current ruby version is 2.5.9.229.
ERROR:  While executing gem ... (Errno::ENOENT)
    No such file or directory @ dir_chdir - /vendor/ruby_2.5/gems/rubygems-update-3.0.3
Updating rubygems-update
The command '/bin/sh -c gem update --system &&       gem install bundler:$BUNDLER_VERSION' returned a non-zero code: 1
Service 'specs' failed to build : Build failed
Error: Process completed with exit code 1.

image

P.S. This error is unrelated to the migration and started appearing during development. It was working just fine in earlier commits.

@reakaleek reakaleek marked this pull request as ready for review December 27, 2022 19:37
.github/workflows/test.yml Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
@reakaleek reakaleek requested a review from estolfo January 3, 2023 10:55
@reakaleek reakaleek merged commit c6cab38 into elastic:main Jan 3, 2023
@reakaleek reakaleek deleted the feature/migrate-jenkinsfile-to-gh-actions-workflow branch January 3, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-ruby Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants