Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postal_code missing from geo object? #663

Closed
willemdh opened this issue Dec 2, 2019 · 1 comment
Closed

postal_code missing from geo object? #663

willemdh opened this issue Dec 2, 2019 · 1 comment

Comments

@willemdh
Copy link
Contributor

willemdh commented Dec 2, 2019

It seems like postal_code is missing from geoip object? When I use the geoip filter in Logstash,

The following fields are mapped with the Logstash geoip filter:

  | t destination.geo.city_name | Ghent
  | t destination.geo.continent_code | EU
  | t destination.geo.country_code2 | BE
  | t destination.geo.country_code3 | BE
  | t destination.geo.country_name | Belgium
  | t destination.geo.ip | 22.12.26.150
  | # destination.geo.latitude | 51.047
  | destination.geo.location | {   "lat": 51.047,   "lon": 3.7206 }
  | # destination.geo.longitude | 3.721
  | # destination.geo.postal_code | 9,000
  | t destination.geo.region_code | VOV
  | t destination.geo.region_name | East Flanders Province
  | t destination.geo.timezone | Europe/Brussels

So there seem to be multiple differences compared to what's already in geoip in ECS? postal_code gets mapped as long,as most postal codes are a number, but not all, resulting in mapping conflicts..

Also I'm having some thoughts on some geoip ecs fields. Didn't we prefer to use objects where possible. So shouldn't geoip be mapped to

geo.region.code instead of geo.region_code
geo.region.name instead of geo.region_name
...

?

@willemdh willemdh changed the title postal_code missingfrom geo object? postal_code missing from geo object? Dec 2, 2019
@ebeahan
Copy link
Member

ebeahan commented Jan 12, 2021

Closing in favor of more recent discussion in #1217

@ebeahan ebeahan closed this as completed Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants