Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tooling] Add --exclude flag to Generator to support field removal testing #1411

Merged
merged 45 commits into from
May 24, 2021
Merged

[Tooling] Add --exclude flag to Generator to support field removal testing #1411

merged 45 commits into from
May 24, 2021

Conversation

djptek
Copy link
Contributor

@djptek djptek commented May 12, 2021

  • Have you signed the contributor license agreement? Y
  • Have you followed the contributor guidelines? Y
  • For proposing substantial changes or additions to the schema, have you reviewed the [RFC process] (https:/elastic/ecs/blob/master/rfcs/README.md)? n/a
  • If submitting code/script changes, have you verified all tests pass locally using make test? Y
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes? n/a
  • Is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed. Y
  • Have you added an entry to the [CHANGELOG.next.md] WIP (https:/elastic/ecs/blob/master/CHANGELOG.next.md)?

@djptek djptek requested review from kgeller and ebeahan May 12, 2021 11:58
@djptek djptek marked this pull request as draft May 12, 2021 12:00
@djptek
Copy link
Contributor Author

djptek commented May 12, 2021

Note: Moved to Draft while fixing regression

@djptek djptek changed the title [Tooling] Add --exclude flag to Generetor to support field removal testing [Tooling] Add --exclude flag to Generator to support field removal testing May 12, 2021
@djptek djptek marked this pull request as ready for review May 12, 2021 12:24
@djptek
Copy link
Contributor Author

djptek commented May 12, 2021 •
edited
Loading

Regression fixed: the files in folder ./rfcs/text/0017 have been included temporarily as I used those for testing, these will not be included in the final commit

@djptek djptek marked this pull request as draft May 12, 2021 12:27
@djptek djptek marked this pull request as ready for review May 12, 2021 12:36
ebeahan
ebeahan reviewed May 12, 2021
View reviewed changes
scripts/generator.py Outdated Show resolved Hide resolved
rfcs/text/0017/exclude-set.yml Outdated Show resolved Hide resolved
scripts/schema/subset_filter.py Outdated Show resolved Hide resolved
@djptek djptek marked this pull request as draft May 14, 2021 09:18
@djptek
Copy link
Contributor Author

djptek commented May 14, 2021

moved to draft while updating unit tests

kgeller
kgeller reviewed May 19, 2021
View reviewed changes
scripts/schema/loader.py Outdated Show resolved Hide resolved
ebeahan
ebeahan reviewed May 19, 2021
View reviewed changes
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refactoring a bit and adding the unit tests!

rfcs/text/0017/exclude-set.yml Outdated Show resolved Hide resolved
scripts/generator.py Show resolved Hide resolved
scripts/tests/unit/test_schema_exclude_filter.py Outdated Show resolved Hide resolved
scripts/schema/exclude_filter.py Outdated Show resolved Hide resolved
@djptek djptek mentioned this pull request May 20, 2021
Closed
@djptek djptek merged commit 581b12e into elastic:master May 24, 2021
This was referenced May 26, 2021
Merged
Merged
Merged
Merged
Closed
Closed
djptek added a commit that referenced this pull request May 26, 2021
@djptek
[Tooling] Add --exclude flag to Generator to support field removal te…
a00eb89 
…sting (#1411) (#1431)

* add --exclude flag to Generator
djptek added a commit that referenced this pull request May 26, 2021
@djptek
[Tooling] Add --exclude flag to Generator to support field removal te…
8e7f91f 
…sting (#1411) (#1432)

* add --exclude flag to Generator
djptek pushed a commit that referenced this pull request May 26, 2021
Revert "[Tooling] Add --exclude flag to Generator to support field re…
b29706a 
…moval testing (#1411) (#1432)"

This reverts commit 8e7f91f.
rylnd added a commit to rylnd/ecs that referenced this pull request May 28, 2021
@rylnd
Merge branch 'master' into threat-enrichment-stage-1
caa8983 
* master:
  Stage 2 changes for RFC 0018 - extending the `threat.*` field set (elastic#1438)
  Remove deprecated `host.user.*` fields (elastic#1439)
  Explicitly include user identifiers in `related.user` field description (elastic#1420)
  Set the merge date on RFC 0018 stage 2 (elastic#1429)
  [RFC] Extend Threat Fieldset - Stage 2 Proposal (elastic#1395)
  [Tooling] Add --exclude flag to Generator to support field removal testing (elastic#1411)
  Add `host.user.*` deprecation notice in field reuse description (elastic#1422)
  Stage 2 changes for RFC 0015 - `elf` header (elastic#1410)
  Stage 3 changes for RFC 0012 - `orchestrator` field set (elastic#1417)
  Support `match_only_text` in Go code generator (elastic#1418)
  Stage 3 Orchestrator RFC (elastic#1343)
  moving into folder (elastic#1416)
  removing use-cases (elastic#1405)
  removing --oss (elastic#1404)
  Set the merge date on RFC 0015 stage 2 (elastic#1409)
  Consolidate `Breaking changes` sections in `CHANGELOG.next` (elastic#1408)
  RFC-Stage-0: Proposal to add a "ticket" schema / field definition to ECS (elastic#1383)
  [RFC] `match_only_text` type migration - Stage 0 (elastic#1396)
  Client port is wrongly documented (elastic#1402) (elastic#1406)
@djptek djptek mentioned this pull request Jun 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebeahan ebeahan ebeahan left review comments

@kgeller kgeller kgeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djptek @ebeahan @kgeller