Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] 0017 Deprecation of log.original Stage 3 Proposal #1465

Merged
merged 9 commits into from
Jun 23, 2021
Merged

[RFC] 0017 Deprecation of log.original Stage 3 Proposal #1465

merged 9 commits into from
Jun 23, 2021

Conversation

djptek
Copy link
Contributor

@djptek djptek commented Jun 17, 2021

  • Have you signed the contributor license agreement? Y
  • Have you followed the contributor guidelines? Y
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process? Y
  • If submitting code/script changes, have you verified all tests pass locally using make test? n/a
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes? n/a
  • Is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed. Y
  • Have you added an entry to the CHANGELOG.next.md? TBC

@djptek djptek marked this pull request as draft June 17, 2021 16:38
@djptek djptek changed the title Stage 3 draft [RFC] 0017 Deprecation of log.original Stage 3 Proposal Jun 18, 2021
@djptek djptek marked this pull request as ready for review June 18, 2021 09:28
@djptek djptek requested review from ebeahan and a team and removed request for ebeahan June 18, 2021 09:28
Copy link
Contributor

@kgeller kgeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rfcs/text/0017-remove-log-original.md Show resolved Hide resolved
rfcs/text/0017-remove-log-original.md Outdated Show resolved Hide resolved
rfcs/text/0017-remove-log-original.md Show resolved Hide resolved
@ebeahan
Copy link
Member

ebeahan commented Jun 21, 2021

A thought I had while reviewing:

We will want to update the log.original field description indicating the field's deprecation and upcoming removal from ECS.

@djptek
Copy link
Contributor Author

djptek commented Jun 22, 2021

We will want to update the log.original field description indicating the field's deprecation and upcoming removal from ECS.

This is referenced at L17 in the RFC and proposed change is here: https:/djptek/ecs/blob/rfc_0017_stage_3/rfcs/text/0017/event.yml

@djptek djptek changed the title [RFC] 0017 Deprecation of log.original Stage 3 Proposal [RFC] 0017 Deprecation of log.original Stage 3 Proposal Jun 23, 2021
@djptek
Copy link
Contributor Author

djptek commented Jun 23, 2021

@elasticmachine run elasticsearch-ci/docs

Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

rfcs/text/0017-remove-log-original.md Outdated Show resolved Hide resolved
@djptek djptek merged commit 6200e56 into elastic:master Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants