Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Swap columns in field reuse table #1472

Merged
merged 3 commits into from
Jun 24, 2021

Conversation

ebeahan
Copy link
Member

@ebeahan ebeahan commented Jun 24, 2021

Summary

Swap positions of the Field Set and Location columns in the Field Reuse sections of the ECS Field Reference docs.

Background

After adding a link to the original field set, long location names were being wrapped when generated on the docs site:

Screen Shot 2021-06-24 at 2 07 07 PM

Solution

Swapping the location of the Field Set and Location columns is a quick solution to render the Location as a single line:

Screen Shot 2021-06-24 at 2 08 14 PM

This does place the field set link in the middle of the table versus on the left-hand side, but I don't think that will be an issue for users.

Docs Preview

@ebeahan ebeahan self-assigned this Jun 24, 2021
@ebeahan ebeahan requested a review from a team June 24, 2021 19:14
@ebeahan ebeahan merged commit 389a72e into elastic:master Jun 24, 2021
@ebeahan ebeahan deleted the docs/reorg-field-reuse-table branch June 24, 2021 20:22
ebeahan added a commit to ebeahan/ecs that referenced this pull request Jun 24, 2021
* switch field set and location columns

* update

* changelog entry
ebeahan added a commit that referenced this pull request Jun 24, 2021
* [DOCS] Swap columns in field reuse table (#1472)

* switch field set and location columns

* update

* changelog entry

* artifacts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants