Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threat intelligence RFCs stage 2 addenda #1504

Merged

Conversation

ebeahan
Copy link
Member

@ebeahan ebeahan commented Jul 6, 2021

Incorporate changes from the threat intelligence addenda for stage 2: #1502

Docs preview

@ebeahan ebeahan self-assigned this Jul 6, 2021
@ebeahan ebeahan marked this pull request as ready for review July 7, 2021 18:01
@ebeahan ebeahan requested review from rylnd, peasead and a team July 7, 2021 18:01
Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave this a once-over:

  • Verified docs preview looks correct
  • Verified that the JSON and YML files correctly declare enrichments as nested, and contain all relevant fields

The only thing potentially missing is an update to the original RFCs themselves? I know the changelog accounts for this, but I'm not sure if we should also include a mention of these changes in RFCs 8 and 21.

@ebeahan
Copy link
Member Author

ebeahan commented Jul 7, 2021

@rylnd #1502 added the changes to each of the two RFC proposals and example field definitions. Or is there something else we should capture?

I did link #1502 at the bottom of both RFCs before merging:

@rylnd
Copy link
Contributor

rylnd commented Jul 7, 2021

I did link #1502 at the bottom of both RFCs before merging:

Ah, yep! 25eb02c is what I was asking about. LGTM!

Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comments; approved!

Copy link
Contributor

@djptek djptek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structure and Language Good, saw a docs word omission while I was in there, opened #1505 to avoid noise here. Deferring to SME for Content

@ebeahan ebeahan merged commit 81b138a into elastic:master Jul 8, 2021
@ebeahan ebeahan deleted the rfc/0008/changes-for-stage-2-addendum branch July 8, 2021 17:00
ebeahan added a commit to ebeahan/ecs that referenced this pull request Jul 8, 2021
* add addenda for RFC 0008 and 0021

* artifacts

* changelog

* correct reusable configuration for pe and registry

* improve descriptions

* reuse cleanup

* artifacts

* additional reuseable configuration cleanup
# Conflicts:
#	experimental/generated/csv/fields.csv
#	generated/csv/fields.csv
ebeahan added a commit to ebeahan/ecs that referenced this pull request Jul 8, 2021
* add addenda for RFC 0008 and 0021

* artifacts

* changelog

* correct reusable configuration for pe and registry

* improve descriptions

* reuse cleanup

* artifacts

* additional reuseable configuration cleanup
# Conflicts:
#	experimental/generated/csv/fields.csv
#	generated/csv/fields.csv
ebeahan added a commit that referenced this pull request Jul 8, 2021
* add addenda for RFC 0008 and 0021

* artifacts

* changelog

* correct reusable configuration for pe and registry

* improve descriptions

* reuse cleanup

* artifacts

* additional reuseable configuration cleanup
ebeahan added a commit that referenced this pull request Jul 8, 2021
* add addenda for RFC 0008 and 0021

* artifacts

* changelog

* correct reusable configuration for pe and registry

* improve descriptions

* reuse cleanup

* artifacts

* additional reuseable configuration cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants