Present beta tooltip for categorization values
#1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebeahan
added a commit
to ebeahan/ecs
that referenced
this pull request
Jul 13, 2021
* include beta tooltip if beta attribute is present * test for presence of beta fields * changelog * add note about beta support in the README
ebeahan
added a commit
to ebeahan/ecs
that referenced
this pull request
Jul 13, 2021
* include beta tooltip if beta attribute is present * test for presence of beta fields * changelog * add note about beta support in the README
ebeahan
added a commit
that referenced
this pull request
Jul 13, 2021
ebeahan
added a commit
that referenced
this pull request
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow for a
betaattribute to be defined on an ECS categorization allowed value and thatbetaattribute's value to be passed into the ECS docs as abetatooltip.This expands the
betalabel supported initially added in #1051.Description
An allowed value defined underneath one of the ECS categorization fields will now support the
betaattribute.It's defined on the desired value:
Will render as part of the allowed values description in the docs:
And will act as a tooltip displaying a
betanotice when moused over: