refactor: replace go-connections tls config with stdlib

[kruskall]

drop docker/go-connections dependency
use crypto/tls config
ignore unused options and keep default ciphers and tls version

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: f8f66e2

History

• 💚 Build #236 succeeded 4bafa3c

[belimawr]

[Question]
That means TLS 1.0 and 1.1 are not accepted any more, right?

That looks like a breaking change because on our docs we state supporting TLS 1.0 and 1.1: https://www.elastic.co/guide/en/beats/filebeat/current/configuration-ssl.html#supported-protocols

[kruskall]

I'm using the same settings as the connections lib to avoid breaking changes. The go-connections lib sets tls12 as the minimum supported version by default: https:/docker/go-connections/blob/5df8d2b30ca886f2d94740ce3c54abd58a5bb2c9/tlsconfig/config.go#L80 and it has been doing that for a while

Afaics It doesn't look like tls 1.0/1.1 was ever supported here.

[leehinman]

unless we can switch everywhere I'd rather keep tlsconfig, that way the tls configuration experience (and errors) are the same everywhere we require the input from the user.

[kruskall]

unless we can switch everywhere I'd rather keep tlsconfig, that way the tls configuration experience (and errors) are the same everywhere we require the input from the user.

Thanks for the feedback!

The reason for this PR is so that we can drop go-connections from beats but I don't have a strong opinion on it! 🙂

[ycombinator]

@kruskall Looking at the conversation between you and @leehinman, should this PR be closed unmerged?