Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more Fleet APIs to Kibana client #122

Merged
merged 7 commits into from
May 10, 2023

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented May 9, 2023

What does this PR do?

This PR enhances the Kibana client to implement methods for the following APIs:

Why is it important?

These APIs will be useful for integration tests to determine the Fleet Server URL for a Fleet-managed policy they're testing with. See https:/elastic/elastic-agent/pull/2618/files#r1188775382.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.md

Author's Checklist

  • [ ]

Related issues

@ycombinator ycombinator changed the title Add List Fleet Server Hosts API to Kibana client Add more APIs to Kibana client May 9, 2023
@ycombinator ycombinator changed the title Add more APIs to Kibana client Add more Fleet APIs to Kibana client May 9, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 9, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-09T19:12:30.817+0000

  • Duration: 8 min 16 sec

Test stats 🧪

Test Results
Failed 0
Passed 783
Skipped 5
Total 788

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@ycombinator ycombinator added the Team:Elastic-Agent Label for the Agent team label May 9, 2023
@ycombinator ycombinator marked this pull request as ready for review May 9, 2023 19:13
@ycombinator ycombinator requested a review from a team as a code owner May 9, 2023 19:13
@ycombinator ycombinator requested review from cmacknz, leehinman and blakerouse and removed request for a team May 9, 2023 19:13
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sonarcloud
Copy link

sonarcloud bot commented May 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ycombinator ycombinator merged commit d0085fb into elastic:main May 10, 2023
@ycombinator ycombinator deleted the kib-client-fleet-server-hosts branch May 10, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants