Fix logging of matching CA certificate #130
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When the 'ca_trusted_fingerprint' matches one of the certificates provided, log success only if the matching certificate is actually a CA, otherwise log that the matching certificate is not a CA.
With current code you can find contradictory logs if the matching log is not a CA:
With the changes here, on the same situation this will be logged:
Why is it important?
To avoid confusion due to the contradictory logs.
Checklist
CHANGELOG.md