[transport] make dial error logging compatible with ECS #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LoggingDiler was logging an error with the field 'network' set as the network type (tcp/upd), however 'network' is an object in ECS, this would cause the log entry to be rejected by Elasticsearch.
belimawr
requested review from
rdner and
faec
and removed request for
a team
💚 Build Succeeded
cc @belimawr |
mauri870
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The LoggingDiler was logging an error with the field 'network' set as the network type (tcp/upd), however 'network' is an object in ECS, this would cause the log entry to be rejected by Elasticsearch.
Why is it important?
It makes our logs compatible with ECS
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have added tests that prove my fix is effective or that my feature works## Author's Checklist## Related issues