Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg][fix] - Filter non-fatal errors and update go.mod #5196

Merged
merged 9 commits into from
Aug 6, 2024
Merged

[pkg][fix] - Filter non-fatal errors and update go.mod #5196

merged 9 commits into from
Aug 6, 2024

Conversation

VihasMakwana
Copy link
Contributor

@VihasMakwana VihasMakwana commented Jul 24, 2024 •
edited
Loading

What does this PR do?

With elastic/elastic-agent-system-metrics#164, we now also expect a list of non-fatal errors (access denied, operation not permitted, invalid parameters etc).
Such errors are safe to ignore, so update the tests
Also,

  • update go.mod

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

This was referenced Jul 24, 2024
Closed
Closed
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 24, 2024

This pull request does not have a backport label. Could you fix it @VihasMakwana? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@michalpristas
Copy link
Contributor

seems like notice in not properly updated, can you run go mod tidy;mage fmt;mage update;mage notice again

@VihasMakwana VihasMakwana marked this pull request as ready for review July 25, 2024 13:08
@VihasMakwana VihasMakwana requested a review from a team as a code owner July 25, 2024 13:08
AndersonQ
AndersonQ reviewed Jul 25, 2024
View reviewed changes
go.mod Outdated
@@ -14,7 +14,7 @@ require (
github.com/elastic/elastic-agent-autodiscover v0.8.0
github.com/elastic/elastic-agent-client/v7 v7.15.0
github.com/elastic/elastic-agent-libs v0.9.15
github.com/elastic/elastic-agent-system-metrics v0.10.4
github.com/elastic/elastic-agent-system-metrics v0.10.6-0.20240723152150-0f81a1e67528
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please release elastic-agent-system-metrics and use the proper version

AndersonQ
AndersonQ reviewed Jul 25, 2024
View reviewed changes
Copy link
Member

@AndersonQ AndersonQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once you fix the elastic-agent-system-metrics it is good to go

@ycombinator ycombinator added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Jul 26, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 26, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b use-multierr-update-gomod upstream/use-multierr-update-gomod
git merge upstream/main
git push upstream use-multierr-update-gomod

@ycombinator ycombinator added the enhancement New feature or request label Jul 30, 2024
@VihasMakwana
Copy link
Contributor Author

@michalpristas @Fae if you can have a look, it's ready for review.

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

blakerouse
blakerouse approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@VihasMakwana VihasMakwana merged commit a1fd2c9 into elastic:main Aug 6, 2024
13 checks passed
@pierrehilbert
Copy link
Contributor

@VihasMakwana shouldn't we backport this on to 8.15?

@VihasMakwana VihasMakwana added backport-8.15 Automated backport to the 8.15 branch with mergify and removed backport-skip labels Aug 6, 2024
mergify bot pushed a commit that referenced this pull request Aug 6, 2024
@VihasMakwana @mergify
[pkg][fix] - Filter non-fatal errors and update go.mod (#5196)
0c048f8 
* fix: update go.mod and test cases

* chore: update notice

* fix: go.mod

* fix: update notice

* fix: update notice, go.mod

* fix: update notice, go.mod

* fix: fix check

* fix: update notice, go.mod to v0.11.0

(cherry picked from commit a1fd2c9)

# Conflicts:
#	NOTICE.txt
#	go.mod
#	go.sum
@mergify mergify bot mentioned this pull request Aug 6, 2024
Merged
7 tasks
pierrehilbert pushed a commit that referenced this pull request Aug 9, 2024
@mergify @VihasMakwana
[8.15](backport #5196) [pkg][fix] - Filter non-fatal errors and updat…
0b814a4 
…e go.mod (#5261)

* [pkg][fix] - Filter non-fatal errors and update go.mod (#5196)

* fix: update go.mod and test cases

* chore: update notice

* fix: go.mod

* fix: update notice

* fix: update notice, go.mod

* fix: update notice, go.mod

* fix: fix check

* fix: update notice, go.mod to v0.11.0

(cherry picked from commit a1fd2c9)

# Conflicts:
#	NOTICE.txt
#	go.mod
#	go.sum

* fix: merge conflice

* fix: go mod tidy

* fix: notice

---------

Co-authored-by: VihasMakwana <[email protected]>
Co-authored-by: Vihas Makwana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonQ AndersonQ AndersonQ left review comments

@blakerouse blakerouse blakerouse approved these changes

@michalpristas michalpristas Awaiting requested review from michalpristas michalpristas is a code owner automatically assigned from elastic/elastic-agent-control-plane

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@VihasMakwana VihasMakwana

Labels
backport-8.15 Automated backport to the 8.15 branch with mergify enhancement New feature or request skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@VihasMakwana @michalpristas @elasticmachine @pierrehilbert @AndersonQ @blakerouse @ycombinator