Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] wrap onRenderChange with a RAF #2135

Closed
markov00 opened this issue Aug 4, 2023 · 2 comments
Closed

[API] wrap onRenderChange with a RAF #2135

markov00 opened this issue Aug 4, 2023 · 2 comments
Labels
API Changes the external API types :chart Chart element related issue enhancement New feature or request good first issue Good for newcomers

Comments

@markov00
Copy link
Member

markov00 commented Aug 4, 2023

As follow up from this issue, #2124 we should wrap again the onRenderChange callback into a RAF to precisely call the function only after the painting is done.
@markov00 markov00 added enhancement New feature or request :chart Chart element related issue API Changes the external API types good first issue Good for newcomers labels Aug 4, 2023
@nickofthyme
Copy link
Collaborator

@markov00 is this different than what @drewdaemon did here? #2131

@markov00
Copy link
Member Author

markov00 commented Aug 7, 2023

fixed by #2131

@markov00 markov00 closed this as completed Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Changes the external API types :chart Chart element related issue enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markov00 @nickofthyme