Enhance StreamResponse handling and update dependencies #121
+183
−204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated `ResponseBuilderDefaults` to include `StreamResponse` in `SpecialTypes`. Refactored `SetBodyCoreAsync` in `DefaultResponseBuilder.cs` for readability and removed unnecessary `using` statements. Modified `RequestCoreAsync` in `HttpWebRequestInvoker.cs` and `BuildResponseAsync` in `InMemoryRequestInvoker.cs` to handle `StreamResponse` types with proper disposal. Updated `Elastic.Transport.csproj` to reference `System.Text.Json` version `8.0.5`.
stevejgordon
force-pushed
the
bug/fix-stream-response
branch
from
eab800f
to
2300050
Compare
Mpdreamz
requested changes
Oct 22, 2024
| { | ||
| var settings = disableDirectStreaming ? _settingsDisableDirectStream : _settings; | ||
| var memoryStreamFactory = new TrackMemoryStreamFactory(); |
There was a problem hiding this comment.
The purpose of this was also to ensure the memory stream factory returned memory streams get disposed properly. I think we should still test this.
How should DisableDirectStreaming: true and StreamResponse behave?
We should have a matrix test over
DisableDirectStreaming | Type of Response
That asserts both the stream of the response AND any memory streams return by the memory stream factory (the real implementation uses a shared pool so returns are very important)
Testing StreamResponse and StringResponse should suffice.
There was a problem hiding this comment.
Yeah, that's a good call out. I'll reintroduce something to cover these scenarios as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
ResponseBuilderDefaultsto includeStreamResponseinSpecialTypes. RefactoredSetBodyCoreAsyncinDefaultResponseBuilder.csfor readability and removed unnecessaryusingstatements. ModifiedRequestCoreAsyncinHttpWebRequestInvoker.csandBuildResponseAsyncinInMemoryRequestInvoker.csto handleStreamResponsetypes with proper disposal. UpdatedElastic.Transport.csprojto referenceSystem.Text.Jsonversion8.0.5.