Support resource_name on AttachmentProcessor #5205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes to #5198 Relates to elastic/elasticsearch#64389
Closed
Mpdreamz
requested changes
Dec 28, 2020
There was a problem hiding this comment.
Looks good to me accept the following failing unit test:
[xUnit.net 00:00:10.3236193] Tests.CodeStandards.Descriptors.DescriptorMethodsTakingSingleValueTypeShouldBeNullable [FAIL]
Failed Tests.CodeStandards.Descriptors.DescriptorMethodsTakingSingleValueTypeShouldBeNullable [227 ms]
Error Message:
Expected breakingDescriptors to be empty, but found {"dateInterval on method Unit of Nest.RateAggregationDescriptor`1 is not nullable", "mode on method Mode of Nest.RateAggregationDescriptor`1 is not nullable"}.
Stack Trace:
github-actions bot
pushed a commit
that referenced
this pull request
Jan 14, 2021
Contributes to #5198 Relates to elastic/elasticsearch#64389
github-actions bot
pushed a commit
that referenced
this pull request
Jan 14, 2021
Contributes to #5198 Relates to elastic/elasticsearch#64389
stevejgordon
added a commit
that referenced
this pull request
Jan 14, 2021
Contributes to #5198 Relates to elastic/elasticsearch#64389 Co-authored-by: Steve Gordon <[email protected]>
stevejgordon
added a commit
that referenced
this pull request
Jan 14, 2021
Contributes to #5198 Relates to elastic/elasticsearch#64389 Co-authored-by: Steve Gordon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #5198
Relates to elastic/elasticsearch#64389