[ESQL] Support date nanos in binary comparisions #109992
Assignees
Labels
:Analytics/ES|QL
AKA ESQL
>enhancement
Team:Analytics
Meta label for analytical engine team (ESQL/Aggs/Geo)
Comments
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this issue
Sep 4, 2024
resolves elastic#109992 Nothing fancy here. Nanosecond dates are still longs, and we can just compare them as longs. Please note that, as mentioned in the linked issue, this only supports comparing date nanos to other date nanos, and not comparing to millisecond dates. With the cast functions added in elastic#111850, users can explicitly cast to millisecond dates (or longs) to compare nanos to other things.
davidkyle
pushed a commit
to davidkyle/elasticsearch
that referenced
this issue
Sep 5, 2024
resolves elastic#109992 Nothing fancy here. Nanosecond dates are still longs, and we can just compare them as longs. Please note that, as mentioned in the linked issue, this only supports comparing date nanos to other date nanos, and not comparing to millisecond dates. With the cast functions added in elastic#111850, users can explicitly cast to millisecond dates (or longs) to compare nanos to other things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Comparing date nanos to other date nanos values is well defined since they're both longs with the same units. For an initial version, I think we should only support comparing to millisecond dates via an explicit cast (we have another ticket for basic casting support already). There's also a discussion issue for autocasting
The text was updated successfully, but these errors were encountered: