Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESQL] Support date nanos on functions that take any type #109998

Closed
12 tasks done
Tracked by #109352
not-napoleon opened this issue Jun 20, 2024 · 1 comment · Fixed by #114056
Closed
12 tasks done
Tracked by #109352

[ESQL] Support date nanos on functions that take any type #109998

not-napoleon opened this issue Jun 20, 2024 · 1 comment · Fixed by #114056
Assignees
Labels
:Analytics/ES|QL AKA ESQL >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@not-napoleon
Copy link
Member

not-napoleon commented Jun 20, 2024

Description

Most of these should be easy:

  • Coalesce
  • Case
  • Greatest
  • Least
  • MV_COUNT
  • MV_DEDUP
  • MV_FIRST
  • MV_LAST
  • MV_MAX
  • MV_MIN
  • MV_SORT
  • MV_SLICE

Most of the work in this ticket should just be wiring up tests, but that's still important to get right.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jun 20, 2024
@not-napoleon not-napoleon self-assigned this Sep 12, 2024
not-napoleon added a commit that referenced this issue Oct 22, 2024
Resolves #109998

For the most part, this is just adding tests. Greater and Least have actual production code changes - notably toEvaluator is modified to map date nanos to the long evaluator. This parallels the work done in #113961. I've added CSV tests and unit tests for all the functions listed in the original ticket.


---------

Co-authored-by: Elastic Machine <[email protected]>
not-napoleon added a commit to not-napoleon/elasticsearch that referenced this issue Oct 22, 2024
…114056)

Resolves elastic#109998

For the most part, this is just adding tests. Greater and Least have actual production code changes - notably toEvaluator is modified to map date nanos to the long evaluator. This parallels the work done in elastic#113961. I've added CSV tests and unit tests for all the functions listed in the original ticket.


---------

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants