-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UnsupportedOperationException in FetchDocValuesPhase with collapse #112646
Labels
>bug
:Search Relevance/Search
Catch all for Search Relevance
Team:Search Relevance
Meta label for the Search Relevance team in Elasticsearch
Comments
benwtrent
added
:Search Relevance/Search
Catch all for Search Relevance
and removed
needs:triage
Requires assignment of a team area label
labels
Sep 11, 2024
elasticsearchmachine
added
the
Team:Search Relevance
Meta label for the Search Relevance team in Elasticsearch
label
Sep 11, 2024
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Indeed, the bug apparently is not fully fixed. I can replicate. Trying to figure out what I missed before. |
Thanks @benwtrent, good to see that a PR is already available. 👍 |
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this issue
Sep 26, 2024
Collapse dynamically will add values to the DocumentField values array. There are a few scenarios where this is immutable and most of these are OK. However, we get in trouble when we create an immutable set for StoredValues which collapse later tries to update. The other option for this fix was to make an array copy for `values` in every `DocumentField` ctor, this seemed very expensive and could get out of hand. So, I decided to fix this one bug instead. closes elastic#112646
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this issue
Sep 26, 2024
Collapse dynamically will add values to the DocumentField values array. There are a few scenarios where this is immutable and most of these are OK. However, we get in trouble when we create an immutable set for StoredValues which collapse later tries to update. The other option for this fix was to make an array copy for `values` in every `DocumentField` ctor, this seemed very expensive and could get out of hand. So, I decided to fix this one bug instead. closes elastic#112646
elasticsearchmachine
pushed a commit
that referenced
this issue
Sep 26, 2024
Collapse dynamically will add values to the DocumentField values array. There are a few scenarios where this is immutable and most of these are OK. However, we get in trouble when we create an immutable set for StoredValues which collapse later tries to update. The other option for this fix was to make an array copy for `values` in every `DocumentField` ctor, this seemed very expensive and could get out of hand. So, I decided to fix this one bug instead. closes #112646
elasticsearchmachine
pushed a commit
that referenced
this issue
Sep 26, 2024
Collapse dynamically will add values to the DocumentField values array. There are a few scenarios where this is immutable and most of these are OK. However, we get in trouble when we create an immutable set for StoredValues which collapse later tries to update. The other option for this fix was to make an array copy for `values` in every `DocumentField` ctor, this seemed very expensive and could get out of hand. So, I decided to fix this one bug instead. closes #112646
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>bug
:Search Relevance/Search
Catch all for Search Relevance
Team:Search Relevance
Meta label for the Search Relevance team in Elasticsearch
Elasticsearch Version
Version: 8.14.3, Build: docker/d55f984299e0e88dee72ebd8255f7ff130859ad0/2024-07-07T22:04:49.882652950Z, JVM: 22.0.1
Installed Plugins
No response
Java Version
bundled
OS Version
Linux hostname 6.6.22-linuxkit #1 SMP Fri Mar 29 12:21:27 UTC 2024 aarch64 aarch64 aarch64 GNU/Linux
Problem Description
In 8.14.2 a fix for a related issue was released, but I think a similar issue still remains. The script below runs fine against ES 7.x, but fails with ES 8.14.3 with an UnsupportedOperationException. The client is returned an error like this:
Steps to Reproduce
Run ES, e.g. with a docker-compose.yml:
Setup an index, add some docs and run a collapse query:
Logs (if relevant)
The text was updated successfully, but these errors were encountered: