Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x-opaque-id to access logs and slow logs #31521

Closed
tomcallahan opened this issue Jun 22, 2018 · 4 comments
Closed

Add x-opaque-id to access logs and slow logs #31521

tomcallahan opened this issue Jun 22, 2018 · 4 comments
Labels
:Core/Infra/Logging Log management and logging utilities >enhancement

Comments

@tomcallahan
Copy link
Contributor

Out of FixItFriday, we decided to close #19778 in favor of this issue, which is to add the x-opaque-id to our access logs and slow logs. This will permit troublesome queries from Kibana to be tracked more accurately.

@tomcallahan tomcallahan added >enhancement :Core/Infra/Logging Log management and logging utilities labels Jun 22, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

imotov added a commit to imotov/elasticsearch that referenced this issue Jun 22, 2018
Add x-opaque-id to search slow logs only. Indexing slow log and audit
logs will be handled as separate PRs.

Relates elastic#31521
imotov added a commit that referenced this issue Jun 25, 2018
Add x-opaque-id to search slow logs only. Indexing slow log and audit
logs will be handled as separate PRs.

Relates #31521
@imotov
Copy link
Contributor

imotov commented Jun 25, 2018

I implemented it for search slow logs and spent some time today trying to apply it to the index slow logs. Unfortunately, with indexing it's not that simple. The main issue here is that indexing slow log can be reached in several different ways - original indexing on primary, as a result of replication and as a result of the recovering from the translog. And because indexing doesn't use a context object, it requires a significant plumbing effort to get id delivered to the slow log and preserved during replication and translog recovery. Since the original issue was about search, I am unsure if implementing something like this would for indexing slow log would be worth the effort.

imotov added a commit that referenced this issue Jun 25, 2018
Add x-opaque-id to search slow logs only. Indexing slow log and audit
logs will be handled as separate PRs.

Relates #31521
imotov added a commit to imotov/elasticsearch that referenced this issue Jul 6, 2018
Logs opaque_id if it is available with all audit log messages.

Relates elastic#31521
imotov added a commit that referenced this issue Jul 9, 2018
Logs opaque_id if it is available with all audit log messages.

Relates #31521
imotov added a commit that referenced this issue Jul 9, 2018
Logs opaque_id if it is available with all audit log messages.

Relates #31521
@imotov
Copy link
Contributor

imotov commented Jul 11, 2018

The opaque_id is now available in audit logging as well #31878. We should discuss if want to undertake adding it to index slow log or we can close this issue.

@imotov imotov added the discuss label Jul 11, 2018
@imotov
Copy link
Contributor

imotov commented Jul 19, 2018

We discussed this and decided that there is really no compelling use case for logging opaque-id in the index slow log and a similar effect can be achieved by simply adding the id as a field to the indexed document. Therefore we are not planning to implement slow indexing log logging as part of this issue.

@imotov imotov removed the discuss label Jul 19, 2018
imotov added a commit to imotov/elasticsearch that referenced this issue Jul 21, 2018
Logs opaque_id if it is available with all audit log messages using
index-based audit log.

Closes elastic#31521
imotov added a commit that referenced this issue Jul 25, 2018
Logs opaque_id if it is available with all audit log messages using
index-based audit log.

Closes #31521
imotov added a commit that referenced this issue Jul 25, 2018
Logs opaque_id if it is available with all audit log messages using
index-based audit log.

Closes #31521
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Logging Log management and logging utilities >enhancement
Projects
None yet
Development

No branches or pull requests

3 participants