-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test] QueryStringQueryBuilderTests fails occasionally #32234
Labels
:Search/Search
Search-related issues that do not fall into other categories
>test-failure
Triaged test failures from CI
Comments
cbuescher
added
:Search/Search
Search-related issues that do not fall into other categories
>test-failure
Triaged test failures from CI
labels
Jul 20, 2018
Pinging @elastic/es-search-aggs |
cbuescher
pushed a commit
that referenced
this issue
Jul 20, 2018
…32236) Currently we check that the queries that QueryStringQueryBuilder#toQuery returns is one out of a list of many Lucene query classes. This list has extended a lot over time, since QueryStringQueryBuilder can build all sort of queries. This makes the test hard to maintain. The recent addition of alias fields which build a BlendedTermQuery show how easy this test breaks. Also the current assertions doesn't add a lot in terms of catching errors. This is why we decided to remove this check. Closes #32234
cbuescher
pushed a commit
that referenced
this issue
Jul 20, 2018
…32236) Currently we check that the queries that QueryStringQueryBuilder#toQuery returns is one out of a list of many Lucene query classes. This list has extended a lot over time, since QueryStringQueryBuilder can build all sort of queries. This makes the test hard to maintain. The recent addition of alias fields which build a BlendedTermQuery show how easy this test breaks. Also the current assertions doesn't add a lot in terms of catching errors. This is why we decided to remove this check. Closes #32234
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Search/Search
Search-related issues that do not fall into other categories
>test-failure
Triaged test failures from CI
Just found this while running tests locally. This tests fails reproducibly with the given seed:
I think I already see the problem and will open a PR with a fix soon.
The text was updated successfully, but these errors were encountered: