Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: org.elasticsearch.client.MachineLearningIT » testStopDataFrameAnalyticsConfig #43924

Closed
alpar-t opened this issue Jul 3, 2019 · 3 comments · Fixed by #43957
Closed

CI: org.elasticsearch.client.MachineLearningIT » testStopDataFrameAnalyticsConfig #43924

alpar-t opened this issue Jul 3, 2019 · 3 comments · Fixed by #43957
Assignees
@dimitris-athanasiou
Labels
:ml Machine learning >test-failure Triaged test failures from CI v7.4.0 v8.0.0-alpha1

Comments

@alpar-t
Copy link
Contributor

alpar-t commented Jul 3, 2019

Example build failure

https://scans.gradle.com/s/dkjie5h3phbx4/tests/43nmsh6ur4gh6-yfbilbda7ksos
https://scans.gradle.com/s/dkjie5h3phbx4/tests/43nmsh6ur4gh6-yfbilbda7ksos

Reproduction line

does not reproduce locally, seems to reproduce when the build is running with --parallel

./gradlew :client:rest-high-level:integTestRunner --tests "org.elasticsearch.client.MachineLearningIT.testStopDataFrameAnalyticsConfig" -Dtests.seed=DFA9D4477D6D5818 -Dtests.security.manager=true -Dtests.locale=ar-SS -Dtests.timezone=America/Cayenne -Dcompiler.java=12 -Druntime.java=11

Example relevant log:

java.lang.AssertionError: 

Expected: <STARTED>
     but: was <REINDEXING>
Close stacktrace
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
at org.junit.Assert.assertThat(Assert.java:956)
at org.junit.Assert.assertThat(Assert.java:923)
at org.elasticsearch.client.MachineLearningIT.testStopDataFrameAnalyticsConfig(MachineLearningIT.java:1440)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:566)
at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1750)
at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:938)
at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:974)
at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:988)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:49)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:45)
at org.apache.lucene.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:48)
at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:64)
at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:47)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:817)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:468)
at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:947)
at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:832)
at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:883)
at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:894)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:45)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:41)
at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:47)
at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:64)
at org.apache.lucene.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:54)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
at java.lang.Thread.run(Thread.java:834)

Frequency

7 times in the past 6 days
@alpar-t alpar-t added >test-failure Triaged test failures from CI :ml Machine learning v8.0.0 v7.4.0 labels Jul 3, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

alpar-t added a commit that referenced this issue Jul 3, 2019
@alpar-t
Mute failing test
5c6ca8d 
Tracked in #43924
alpar-t added a commit that referenced this issue Jul 3, 2019
@alpar-t
Mute failing test
3250cc5 
Tracked in #43924
@dimitris-athanasiou dimitris-athanasiou self-assigned this Jul 3, 2019
@alpar-t
Copy link
Contributor Author

alpar-t commented Jul 3, 2019 •
edited
Loading

muted in 5c6ca8d on master and 3250cc5 in 7.x

@dimitris-athanasiou
Copy link
Contributor

Ah, this is so simple actually. We call start and assert that the state is started but it could very well be reindexing or even analyzing depending how fast things go. I'll raise a fix.

dimitris-athanasiou added a commit to dimitris-athanasiou/elasticsearch that referenced this issue Jul 4, 2019
@dimitris-athanasiou
[TEST][ML] Fix assertion after starting df-analytics job
f5e299b 
In MachineLearningIT.testStopDataFrameAnalytics we call start and
then assert the state is `started`. However, if things go fast enough,
the state could have already changed to `reindexing` or `analyzing`.
The test has been failing occasionally due to the state being
`reindexing`. We fix this by simply asserting the state is either
of `started`, `reindexing` or `analyzing`.

Closes elastic#43924
@dimitris-athanasiou dimitris-athanasiou mentioned this issue Jul 4, 2019
Merged
pull bot pushed a commit to Mattlk13/elasticsearch that referenced this issue Jul 4, 2019
@dimitris-athanasiou
[TEST][ML] Fix assertion after starting df-analytics job (elastic#43957)
20e0de9 
In MachineLearningIT.testStopDataFrameAnalytics we call start and
then assert the state is `started`. However, if things go fast enough,
the state could have already changed to `reindexing` or `analyzing`.
The test has been failing occasionally due to the state being
`reindexing`. We fix this by simply asserting the state is either
of `started`, `reindexing` or `analyzing`.

Closes elastic#43924
dimitris-athanasiou added a commit to dimitris-athanasiou/elasticsearch that referenced this issue Jul 4, 2019
@dimitris-athanasiou
[TEST][ML] Fix assertion after starting df-analytics job (elastic#43957)
6b21af5 
In MachineLearningIT.testStopDataFrameAnalytics we call start and
then assert the state is `started`. However, if things go fast enough,
the state could have already changed to `reindexing` or `analyzing`.
The test has been failing occasionally due to the state being
`reindexing`. We fix this by simply asserting the state is either
of `started`, `reindexing` or `analyzing`.

Closes elastic#43924
@dimitris-athanasiou dimitris-athanasiou mentioned this issue Jul 4, 2019
Merged
dimitris-athanasiou added a commit to dimitris-athanasiou/elasticsearch that referenced this issue Jul 4, 2019
@dimitris-athanasiou
[7.3][TEST][ML] Fix assertion after starting df-analytics job (elasti…
b21bbba 
…c#43957)

In MachineLearningIT.testStopDataFrameAnalytics we call start and
then assert the state is `started`. However, if things go fast enough,
the state could have already changed to `reindexing` or `analyzing`.
The test has been failing occasionally due to the state being
`reindexing`. We fix this by simply asserting the state is either
of `started`, `reindexing` or `analyzing`.

Closes elastic#43924
@dimitris-athanasiou dimitris-athanasiou mentioned this issue Jul 4, 2019
Merged
dimitris-athanasiou added a commit that referenced this issue Jul 4, 2019
@dimitris-athanasiou
[7.3][TEST][ML] Fix assertion after starting df-analytics job (#43957) (
e2286aa 
#43968)

In MachineLearningIT.testStopDataFrameAnalytics we call start and
then assert the state is `started`. However, if things go fast enough,
the state could have already changed to `reindexing` or `analyzing`.
The test has been failing occasionally due to the state being
`reindexing`. We fix this by simply asserting the state is either
of `started`, `reindexing` or `analyzing`.

Closes #43924
dimitris-athanasiou added a commit that referenced this issue Jul 4, 2019
@dimitris-athanasiou
[TEST][ML] Fix assertion after starting df-analytics job (#43957) (#4…
2a70df4 
…3967)

In MachineLearningIT.testStopDataFrameAnalytics we call start and
then assert the state is `started`. However, if things go fast enough,
the state could have already changed to `reindexing` or `analyzing`.
The test has been failing occasionally due to the state being
`reindexing`. We fix this by simply asserting the state is either
of `started`, `reindexing` or `analyzing`.

Closes #43924
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dimitris-athanasiou dimitris-athanasiou

Labels
:ml Machine learning >test-failure Triaged test failures from CI v7.4.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TEST][ML] Fix assertion after starting df-analytics job dimitris-athanasiou/elasticsearch
4 participants
@jakelandis @alpar-t @dimitris-athanasiou @elasticmachine