Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: VariableWidthHistogramAggregatorTests#testMultipleSegments #60673

Closed
nik9000 opened this issue Aug 4, 2020 · 8 comments · Fixed by #60936
Closed

CI: VariableWidthHistogramAggregatorTests#testMultipleSegments #60673

nik9000 opened this issue Aug 4, 2020 · 8 comments · Fixed by #60936
Assignees
Labels
:Analytics/Aggregations Aggregations Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-failure Triaged test failures from CI

Comments

@nik9000
Copy link
Member

nik9000 commented Aug 4, 2020

Error Message

java.lang.AssertionError: expected: but was:

Stacktrace

java.lang.AssertionError: expected:<false> but was:<true>
	at __randomizedtesting.SeedInfo.seed([7B50D97E959CDE64:C7276C27523B7221]:0)
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failNotEquals(Assert.java:834)
	at org.junit.Assert.assertEquals(Assert.java:118)
	at org.junit.Assert.assertEquals(Assert.java:144)
	at org.elasticsearch.search.aggregations.bucket.histogram.VariableWidthHistogramAggregatorTests.lambda$testMultipleSegments$31(VariableWidthHistogramAggregatorTests.java:442)
	at org.elasticsearch.search.aggregations.bucket.histogram.VariableWidthHistogramAggregatorTests.executeTestCase(VariableWidthHistogramAggregatorTests.java:638)
	at org.elasticsearch.search.aggregations.bucket.histogram.VariableWidthHistogramAggregatorTests.testSearchAndReduceCase(VariableWidthHistogramAggregatorTests.java:576)
	at org.elasticsearch.search.aggregations.bucket.histogram.VariableWidthHistogramAggregatorTests.testMultipleSegments(VariableWidthHistogramAggregatorTests.java:429)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1750)
@nik9000 nik9000 added :Search/Search Search-related issues that do not fall into other categories >test-failure Triaged test failures from CI labels Aug 4, 2020
@nik9000 nik9000 self-assigned this Aug 4, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@elasticmachine elasticmachine added the Team:Search Meta label for search team label Aug 4, 2020
@jimczi jimczi added :Analytics/Aggregations Aggregations and removed :Search/Search Search-related issues that do not fall into other categories labels Aug 4, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Aggregations)

@elasticmachine elasticmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) and removed Team:Search Meta label for search team labels Aug 4, 2020
@nik9000
Copy link
Member Author

nik9000 commented Aug 6, 2020

I couldn't get this to reproduce, either with the reproduction line from the failing build's reproduce line or by running it locally a couple thousand times. I imagine #60683 has changed it. If this comes up again, I'll take another look. But for now I'll close.

@nik9000 nik9000 closed this as completed Aug 6, 2020
@nik9000
Copy link
Member Author

nik9000 commented Aug 10, 2020

I'm able to reproduce this against a8a34ec with:

 ./gradlew ':server:test' --tests "org.elasticsearch.search.aggregations.bucket.histogram.VariableWidthHistogramAggregatorTests.testMultipleSegments" -Dtests.seed=84205C35358D3897 -Dtests.security.manager=true -Dtests.locale=ar-JO -Dtests.timezone=Canada/Newfoundland -Druntime.java=11

@nik9000 nik9000 reopened this Aug 10, 2020
@nik9000
Copy link
Member Author

nik9000 commented Aug 10, 2020

This happens because we have a test that randomizes stuff pretty hard and it had some assumptions about the shape of the documents that turn out not to be true. Protip: the results are pretty wonky when you only allow a few pieces docs per shard and ask for very few clusters. This should only be a testing problem. Hopefully.

nik9000 added a commit to nik9000/elasticsearch that referenced this issue Aug 10, 2020
This test assumed some random bounds that turned out not to hold in some
cases.

Closes elastic#60673
nik9000 added a commit that referenced this issue Sep 3, 2020
This test assumed some random bounds that turned out not to hold in some
cases.

Closes #60673
nik9000 added a commit to nik9000/elasticsearch that referenced this issue Sep 3, 2020
This test assumed some random bounds that turned out not to hold in some
cases.

Closes elastic#60673
nik9000 added a commit that referenced this issue Sep 3, 2020
This test assumed some random bounds that turned out not to hold in some
cases.

Closes #60673
@hendrikmuhs
Copy link
Contributor

@nik9000 This happened again in 7.9: https://gradle-enterprise.elastic.co/s/3cd5fb2vt6gau

If I get it right, there is no 7.9 backport. Should this be backported?

@nik9000
Copy link
Member Author

nik9000 commented Nov 5, 2020

If I get it right, there is no 7.9 backport. Should this be backported?

I thought that the 7.9 branch was "mostly dead" so we don't backport test fixes. Are we still running them consistently?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-failure Triaged test failures from CI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants