Fix NPE & empty result handling in CountOnlyQueryPhaseResultConsumer #103203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwtrent
added
>bug
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
|
Hi @benwtrent, I've created a changelog YAML for you. |
javanna
approved these changes
Dec 8, 2023
|
@elasticmachine update branch |
benwtrent
added
the
auto-merge-without-approval
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Dec 8, 2023
…lastic#103203) Query results can be "null" in that they are a null instance, containing no information from the shard. Additionally, if we see no results, its an empty reduce phase. This code was introduced into 8.12, which has yet to be released, but flagging as a bug for clarity.
💚 Backport successful
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query results can be "null" in that they are a null instance, containing no information from the shard.
Additionally, if we see no results, its an empty reduce phase.
This code was introduced into 8.12, which has yet to be released, but flagging as a bug for clarity.