Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix routing_path when template has multiple path_match and multi-fields #104418

Merged
merged 6 commits into from
Jan 16, 2024
Merged

Fix routing_path when template has multiple path_match and multi-fields #104418

merged 6 commits into from
Jan 16, 2024

Conversation

felixbarny
Copy link
Member

Fixes #104400

@felixbarny felixbarny added >bug :StorageEngine/TSDB You know, for Metrics labels Jan 16, 2024
@elasticsearchmachine elasticsearchmachine added v8.13.0 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels Jan 16, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @felixbarny, I've created a changelog YAML for you.

kkrik-es
kkrik-es approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@kkrik-es kkrik-es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nits, looks good otherwise.

martijnvg
martijnvg approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@felixbarny felixbarny added Team:StorageEngine and removed needs:triage Requires assignment of a team area label labels Jan 16, 2024
@felixbarny
Copy link
Member Author

@elasticsearchmachine run elasticsearch-ci/bwc-snapshots

@felixbarny
Copy link
Member Author

@elasticsearchmachine update branch

@felixbarny
Copy link
Member Author

@elasticmachine update branch

@felixbarny felixbarny merged commit 24c4bca into elastic:main Jan 16, 2024
14 checks passed
@felixbarny felixbarny deleted the fix-routing-path-multiple-path-match-multi-fields branch January 16, 2024 19:27
@felixbarny felixbarny mentioned this pull request Jan 16, 2024
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.12

felixbarny added a commit to felixbarny/elasticsearch that referenced this pull request Jan 16, 2024
@felixbarny
Fix routing_path when template has multiple path_match and multi-fiel…
6e91e36 
…ds (elastic#104418)
elasticsearchmachine pushed a commit that referenced this pull request Jan 16, 2024
@felixbarny
Fix routing_path when template has multiple path_match and multi-fiel…
96d83cd 
…ds (#104418) (#104431)
@gsantoro gsantoro mentioned this pull request Jan 17, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkrik-es kkrik-es kkrik-es approved these changes

@martijnvg martijnvg martijnvg approved these changes

@gsantoro gsantoro gsantoro approved these changes

Assignees
No one assigned
Labels
>bug external-contributor Pull request authored by a developer outside the Elasticsearch team :StorageEngine/TSDB You know, for Metrics Team:StorageEngine v8.12.1 v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A Dynamic template with two path_match fails in TSDB
6 participants
@felixbarny @elasticsearchmachine @martijnvg @gsantoro @kkrik-es @elasticmachine