Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add range and regexp Intervals #111465

Merged

Conversation

mayya-sharipova
Copy link
Contributor

@mayya-sharipova mayya-sharipova commented Jul 30, 2024

apache/lucene#13569 introduced IntervalsSource for range and regexp queries. This exposes these features in ES.

This is done to achieve parity with Span queries that support regexp and range.

Relates to #110491

Lucene/pull/13562 introduced IntervalsSource for range and
regexp queries. This exposes these features in ES.

This is done to achieve parity with Span queries that support
regexp and range.

Relates to elastic#110491
Copy link
Contributor

Documentation preview:

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Jul 30, 2024
`regexp` pattern, see <<regexp-syntax, Regular expression syntax>>.

WARNING: Avoid using wildcard patterns, such as `.*` or `.*?+``. This can
increase the iterations needed to find matching terms and slow search
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra space here

Copy link
Contributor

@john-wagster john-wagster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@benwtrent benwtrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't forget to manually add a changes file to track the feature.

@mayya-sharipova
Copy link
Contributor Author

@elasticsearchmachine test this please

@mayya-sharipova
Copy link
Contributor Author

@elasticsearchmachine run elasticsearch-ci/packaging-tests-windows-sample

@mayya-sharipova
Copy link
Contributor Author

@elasticsearchmachine run elasticsearch-ci/windows-2019 / default-windows-archive / packaging-tests-windows-sample

@mayya-sharipova
Copy link
Contributor Author

@elasticsearchmachine test this please

@mayya-sharipova
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/part-1

@mayya-sharipova
Copy link
Contributor Author

@elasticsearchmachine run elasticsearch-ci/part-1

@mayya-sharipova
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/part-1

@mayya-sharipova mayya-sharipova merged commit 92c5521 into elastic:lucene_snapshot Aug 26, 2024
15 checks passed
mayya-sharipova added a commit to mayya-sharipova/elasticsearch that referenced this pull request Aug 27, 2024
Lucene/pull/13562 introduced IntervalsSource for range and
regexp queries. This exposes these features in ES.

This is done to achieve parity with Span queries that support
regexp and range.

Relates to elastic#110491
javanna pushed a commit that referenced this pull request Aug 29, 2024
Lucene/pull/13562 introduced IntervalsSource for range and
regexp queries. This exposes these features in ES.

This is done to achieve parity with Span queries that support
regexp and range.

Relates to #110491
}

@Override
public void writeTo(StreamOutput out) throws IOException {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mayya-sharipova while looking over the diff between the lucene_snapshot branch and upstream, I noticed this new named writable. Will this need to be accompanied by a new transport version - to indicate the change/addition of the new serialisable type?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :Search Relevance/Search Catch all for Search Relevance Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants