-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add range and regexp Intervals #111465
Add range and regexp Intervals #111465
Conversation
Lucene/pull/13562 introduced IntervalsSource for range and regexp queries. This exposes these features in ES. This is done to achieve parity with Span queries that support regexp and range. Relates to elastic#110491
Documentation preview: |
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
`regexp` pattern, see <<regexp-syntax, Regular expression syntax>>. | ||
|
||
WARNING: Avoid using wildcard patterns, such as `.*` or `.*?+``. This can | ||
increase the iterations needed to find matching terms and slow search |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: extra space here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't forget to manually add a changes file to track the feature.
@elasticsearchmachine test this please |
@elasticsearchmachine run elasticsearch-ci/packaging-tests-windows-sample |
@elasticsearchmachine run elasticsearch-ci/windows-2019 / default-windows-archive / packaging-tests-windows-sample |
@elasticsearchmachine test this please |
@elasticmachine run elasticsearch-ci/part-1 |
@elasticsearchmachine run elasticsearch-ci/part-1 |
@elasticmachine run elasticsearch-ci/part-1 |
Lucene/pull/13562 introduced IntervalsSource for range and regexp queries. This exposes these features in ES. This is done to achieve parity with Span queries that support regexp and range. Relates to elastic#110491
Lucene/pull/13562 introduced IntervalsSource for range and regexp queries. This exposes these features in ES. This is done to achieve parity with Span queries that support regexp and range. Relates to #110491
} | ||
|
||
@Override | ||
public void writeTo(StreamOutput out) throws IOException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mayya-sharipova while looking over the diff between the lucene_snapshot
branch and upstream, I noticed this new named writable. Will this need to be accompanied by a new transport version - to indicate the change/addition of the new serialisable type?
apache/lucene#13569 introduced IntervalsSource for range and regexp queries. This exposes these features in ES.
This is done to achieve parity with Span queries that support regexp and range.
Relates to #110491