Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh translog stats after translog trimming in NoOpEngine #43825

Merged
merged 2 commits into from
Jul 3, 2019
Merged

Refresh translog stats after translog trimming in NoOpEngine #43825

merged 2 commits into from
Jul 3, 2019

Conversation

tlrx
Copy link
Member

@tlrx tlrx commented Jul 1, 2019

This pull request changes NoOpEngine so that it refreshes its translog stats once translog is trimmed.

Relates #43156

@tlrx tlrx added >enhancement :Distributed/Engine Anything around managing Lucene and the Translog in an open shard. v8.0.0 v7.3.0 labels Jul 1, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

dnhatn
dnhatn approved these changes Jul 1, 2019
View reviewed changes
Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ywelsch
ywelsch approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2

@tlrx
Copy link
Member Author

tlrx commented Jul 1, 2019

@elasticmachine run elasticsearch-ci/1

@tlrx
Copy link
Member Author

tlrx commented Jul 2, 2019

@elasticmachine update branch

@tlrx
Copy link
Member Author

tlrx commented Jul 2, 2019

@elasticmachine run elasticsearch-ci/1

@tlrx tlrx merged commit d87c9fd into elastic:master Jul 3, 2019
@tlrx tlrx deleted the refresh-translog-stats-after-trimming branch July 3, 2019 06:39
@tlrx
Copy link
Member Author

tlrx commented Jul 3, 2019

Thanks @dnhatn and @ywelsch

tlrx added a commit that referenced this pull request Jul 3, 2019
@tlrx
Refresh translog stats after translog trimming in NoOpEngine (#43825)
365dfe8 
This commit changes NoOpEngine so that it refreshes its translog 
stats once translog is trimmed.

Relates #43156
@tlrx tlrx mentioned this pull request Jul 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywelsch ywelsch ywelsch approved these changes

@dnhatn dnhatn dnhatn approved these changes

Assignees

@ywelsch ywelsch

@dnhatn dnhatn

Labels
:Distributed/Engine Anything around managing Lucene and the Translog in an open shard. >enhancement v7.3.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tlrx @elasticmachine @ywelsch @dnhatn @jakelandis