Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For the fields fetch phase, avoid reloading stored fields. #58196

Merged
merged 3 commits into from
Jun 17, 2020
Merged

For the fields fetch phase, avoid reloading stored fields. #58196

merged 3 commits into from
Jun 17, 2020

Commits on Jun 16, 2020

  1. For the fields fetch phase, avoid reloading stored fields. 

    This PR updates FetchFieldsPhase to override hitExecute instead of hitsExecute
(plural). This way, we can make sure that the stored fields (including _source)
are only loaded once per hit as part of FetchPhase.
    @jtibshirani
    jtibshirani committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    2c7279d View commit details
    Browse the repository at this point in the history

  2. Make sure to load _source when stored_fields are requested.

    @jtibshirani
    jtibshirani committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    b1ff79a View commit details
    Browse the repository at this point in the history

  3. Small simplification to YAML test.

    @jtibshirani
    jtibshirani committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    02c5c59 View commit details
    Browse the repository at this point in the history