Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace AggregatorTestCase#search with AggregatorTestCase#searchAndReduce #60816

Merged

Commits on Aug 6, 2020

  1. Replace AggregatorTestCase#search with AggregatorTestCase#searchAndRe…

    …duce (elastic#60683)
    
    * Replace AggregatorTestCase#search with AggregatorTestCase#searchAndReduce
    
    This commit removes the ability to test the top level result of an aggregator
    before it runs the final reduce. All aggregator tests that use AggregatorTestCase#search
    are rewritten with AggregatorTestCase#searchAndReduce in order to ensure that we test
    the final output (the one sent to the end user) rather than an intermediary result
    that could be different.
    This change also removes spurious commits triggered on top of a random index writer.
    These commits slow down the tests and are redundant with the commits that the
    random index writer performs.
    jimczi committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    bd8f3a7 View commit details
    Browse the repository at this point in the history
  2. fix typo in backport

    jimczi committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    fa199fe View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8e96c40 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7b3aea1 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2020

  1. Configuration menu
    Copy the full SHA
    990d7fe View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2020

  1. Configuration menu
    Copy the full SHA
    db5ffb1 View commit details
    Browse the repository at this point in the history