Fixing a problem with potential dirty read of a token document on token refresh #64031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigPandaToo
added
>bug
v7.11.0
v8.0.0
Team:Security
|
Could you please add @jkakavas as a reviewer as well since he knows more about this part of code? Thanks |
jkakavas
reviewed
Oct 22, 2020
x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/authc/TokenService.java
Outdated
Show resolved
Hide resolved
Adding CreateTokenResult to hold authentication object
|
@elasticmachine update branch |
ywangd
approved these changes
Oct 26, 2020
x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/authc/TokenService.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/elasticsearch/xpack/security/action/token/TransportRefreshTokenAction.java
Show resolved
Hide resolved
jkakavas
reviewed
Oct 26, 2020
x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/authc/TokenService.java
Show resolved
Hide resolved
...src/main/java/org/elasticsearch/xpack/security/action/token/TransportRefreshTokenAction.java
Show resolved
Hide resolved
x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/authc/TokenService.java
Show resolved
Hide resolved
x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/authc/TokenService.java
Show resolved
Hide resolved
.../org/elasticsearch/xpack/security/action/saml/TransportSamlInvalidateSessionActionTests.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine update branch |
Adding CreateTokenResult to hold authentication object
BigPandaToo
added a commit
to BigPandaToo/elasticsearch
that referenced
this pull request
Oct 26, 2020
…en refresh (elastic#64031) * Fixing a problem with potential dirty read of a token document. Related to elastic#59685 * Fixing a problem with potential dirty read of a token document. Adding CreateTokenResult to hold authentication object * Fixing a problem with potential dirty read of a token document. Adding CreateTokenResult to hold authentication object Co-authored-by: Elastic Machine <[email protected]>
BigPandaToo
added a commit
that referenced
this pull request
Oct 26, 2020
…en refresh (#64031) (#64178) * Fixing a problem with potential dirty read of a token document on token refresh (#64031) * Fixing a problem with potential dirty read of a token document. Related to #59685 * Fixing a problem with potential dirty read of a token document. Adding CreateTokenResult to hold authentication object * Fixing a problem with potential dirty read of a token document. Adding CreateTokenResult to hold authentication object Co-authored-by: Elastic Machine <[email protected]> * Fixing tests failures Co-authored-by: Elastic Machine <[email protected]>
|
Hi @BigPandaToo Not sure if you have talked to @jkakavas, often times we would wait for approvals from all requested reviewers before merging a PR. It's not a requirement, I think our team just kinda spontaneously got into and settled on this habit. |
|
@ywangd Yes, we talked. I thought one LGTM is enough. Will know. |
ywangd
added
>non-issue
:Security/Authentication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in (#55816) #55816 (comment)
Related to #59685