Add hard_bounds support for histogram field-based histograms #64246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hard_bounds should now support histogram fields, previously hard bounds on histogram fields were ignored. Closes elastic#62124
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
elasticmachine
added
the
Team:Analytics
not-napoleon
approved these changes
Oct 28, 2020
| } | ||
| } | ||
|
|
||
| public void testHardBoundsOnHistogram() throws Exception { |
There was a problem hiding this comment.
I'm confused, is this a different test than the one above it? If so, I'm missing what's different.
There was a problem hiding this comment.
No, it's the same, I will remove it. Thanks for catching it! I was going to turn it this into a histogram field test before I realized that I cannot put it here and it needs to go into x-pack because of dependencies.
|
@elasticmachine update branch |
imotov
added a commit
to imotov/elasticsearch
that referenced
this pull request
Oct 28, 2020
…#64246) hard_bounds should now support histogram fields, previously hard bounds on histogram fields were ignored. Closes elastic#62124
imotov
added a commit
that referenced
this pull request
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hard_bounds should now support histogram fields, previously hard bounds
on histogram fields were ignored.
Closes #62124