-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make legacy template noop updates not change cluster state #64493
Conversation
When a legacy template does not change, there is no need to create and publish a new cluster state, rather the update should be a noop. Relates to elastic#57851 Resolves elastic#57662
Pinging @elastic/es-core-features (:Core/Features/Indices APIs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this Lee.
LGTM
@@ -727,7 +749,6 @@ public void testFindV2InvalidGlobalTemplate() { | |||
} | |||
} | |||
|
|||
@AwaitsFix(bugUrl = "https:/elastic/elasticsearch/pull/57393") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be related to composable templates, the mentioned PR was abandoned though. Is this really fixed? Or was this muted by accident initially?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was fixed in the past with Julie's mappings merging, the test was just never unmuted (it's fixed now though)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dakrone, LGTM2
…4493) When a legacy template does not change, there is no need to create and publish a new cluster state, rather the update should be a noop. Relates to elastic#57851 Resolves elastic#57662
Similar to elastic/beats#22357, setup.template.overwrite could potentially overload Elasticsearch with too many update requests. On Elasticsearch side, it will be addressed in newer versions by introducing no-op updates which will be available from 7.11+ elastic/elasticsearch#64493 See also elastic/elasticsearch#57662 Thought having some warnings in the APM setting here should prevent users unwittingly leave template auto-creation on across large number of APM.
When a legacy template does not change, there is no need to create and publish a new cluster state,
rather the update should be a noop.
Relates to #57851
Resolves #57662