Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing X-Pack repositories REST specs #65548

Merged

Conversation

stevejgordon
Copy link
Contributor

While working on the .NET client code-gen, I noticed that a new experimental X-Pack API was added for repositories in 7.10.0, but is missing a REST spec required for client code generation. This PR adds the specs for the two new endpoints.

API was added in #60371

Please let me know what (if anything) needs to happen to backport to 7.10 and 7.x?

@stevejgordon stevejgordon added :Core/Infra/REST API REST infrastructure and utilities Team:Clients Meta label for clients team v7.10.0 labels Nov 26, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/clients-team (Team:Clients)

@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Nov 26, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mpdreamz
Copy link
Member

Mpdreamz commented Dec 7, 2020

@fcofdez this LGTM, mind giving this a quick look over since this is your new API? 👍

@Mpdreamz
Copy link
Member

Mpdreamz commented Dec 7, 2020

Jenkins run elasticsearch-ci/2 please

Copy link
Contributor

@fcofdez fcofdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

A new experimental X-Pack API was added for repositories, but is missing a REST spec. The API was added in elastic#60371
@stevejgordon stevejgordon force-pushed the rest-specs/repositories-metering-api branch from a2f846b to 00ba10e Compare July 15, 2021 15:04
@stevejgordon
Copy link
Contributor Author

Apologies @fcofdez, I've just noticed that I let this PR get stale. Since these still need to be added I have rebased them and updated them to include some of the latest spec fields such as visibility. Which version labels would be best to add these? Would 7.15.0 and 8.0.0 be enough?

@fcofdez
Copy link
Contributor

fcofdez commented Jul 16, 2021

No worries @stevejgordon :). 7.15.0 and 8.0.0 versions are fine. 👍

@stevejgordon stevejgordon added v7.15.0 auto-backport Automatically create backport pull requests when merged labels Jul 16, 2021
@stevejgordon stevejgordon merged commit 1e7e92d into elastic:master Jul 16, 2021
@stevejgordon stevejgordon deleted the rest-specs/repositories-metering-api branch July 16, 2021 09:55
elasticsearchmachine pushed a commit to elasticsearchmachine/elasticsearch that referenced this pull request Jul 16, 2021
* Add missing repositories API REST specs

A new experimental X-Pack API was added for repositories, but is missing a REST spec. The API was added in elastic#60371

* Move this under the nodes namespace

* Rename max_version_to_clear parameter

* Update docs URL to use current
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
7.x

stevejgordon added a commit that referenced this pull request Jul 16, 2021
* Add missing repositories API REST specs

A new experimental X-Pack API was added for repositories, but is missing a REST spec. The API was added in #60371

* Move this under the nodes namespace

* Rename max_version_to_clear parameter

* Update docs URL to use current

Co-authored-by: Steve Gordon <[email protected]>
ywangd pushed a commit to ywangd/elasticsearch that referenced this pull request Jul 30, 2021
* Add missing repositories API REST specs

A new experimental X-Pack API was added for repositories, but is missing a REST spec. The API was added in elastic#60371

* Move this under the nodes namespace

* Rename max_version_to_clear parameter

* Update docs URL to use current
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :Core/Infra/REST API REST infrastructure and utilities >non-issue Team:Clients Meta label for clients team Team:Core/Infra Meta label for core/infra team v7.15.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants