Service Accounts - auditing tests for existing fields #71668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywangd
added
>test
|
Pinging @elastic/es-security (Team:Security) |
|
@tvernum We have a task says "auditing for creating API based token". But I don't think it needs any specialised tests. The existing tests in |
I think we're good because the name of the token is included in the request so the audit should be fine. It's probably worth looking at the audit log and making sure there's no surprises, but I'm happy not to have specific tests. |
|
@elasticmachine update branch |
|
@elasticmachine update branch |
mark-vieira
pushed a commit
that referenced
this pull request
Apr 15, 2021
This PR ensure existing auditing tests cover service account authentication. It makes sure compatible existing fields also work for service accounts.
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Apr 18, 2021
This PR ensure existing auditing tests cover service account authentication. It makes sure compatible existing fields also work for service accounts.
ywangd
added a commit
that referenced
this pull request
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensure existing auditing tests cover service account authentication. It makes sure compatible existing fields also work for service accounts.