Create float type family #96625
Closed
Create float type family #96625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v8.9.0
needs:triage
JVerwolf
commented
Jun 6, 2023
| @@ -326,6 +326,11 @@ public Float parse(XContentParser parser, boolean coerce) throws IOException { | |||
| return parsed; | |||
| } | |||
|
|
|||
| @Override | |||
| public String familyTypeName() { | |||
| return NumberFieldMapper.NumberType.FLOAT.typeName(); | |||
There was a problem hiding this comment.
I decided to keep this very simple instead of adding more mechanism/abstraction for Type Families here. I figure we can decide to add that once we have a few more use cases to generalize from. Happy to change that though based on feedback. WDYT?
javanna
added
:Search Foundations/Mapping
|
Pinging @elastic/es-search (Team:Search) |
|
Hi @JVerwolf, I've created a changelog YAML for you. |
astefan
reviewed
Jun 8, 2023
| @@ -19,6 +19,34 @@ | |||
|
|
|||
| public class FieldCapabilitiesFilterTests extends MapperServiceTestCase { | |||
|
|
|||
| /** | |||
| * Tests that the field family type is returned instead of the actual field type. | |||
| * `half_float` is chosen arbitrarily for this purpose. | |||
There was a problem hiding this comment.
Instead of arbitrarily choosing half_float you could use a randomFrom and list there all the "float" types.
|
run elasticsearch-ci/bwc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines
float,half_float, andscaled_floatinto the same field type family.Relates to #58483
Closes #67723