Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add synonyms feature for test clusters #97658

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

mayya-sharipova
Copy link
Contributor

Fix for #97334 where incorrect feature name was provided.

Closes #96641, #97177

Fix for elastic#97334 where incorrect feature name was provided.

Closes elastic#96641, elastic#97177
@mayya-sharipova mayya-sharipova added >test Issues or PRs that are addressing/adding tests :Search Relevance/Analysis How text is split into tokens v8.9.0 v8.10.0 labels Jul 13, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticsearchmachine elasticsearchmachine added the Team:Search Meta label for search team label Jul 13, 2023
Copy link
Member

@carlosdelest carlosdelest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

There are other places where we have the same error, I have changed them.

@mayya-sharipova mayya-sharipova merged commit 321110e into elastic:main Jul 13, 2023
@mayya-sharipova mayya-sharipova deleted the synonyms-test2 branch July 13, 2023 15:34
@mayya-sharipova mayya-sharipova added auto-backport Automatically create backport pull requests when merged and removed auto-backport Automatically create backport pull requests when merged labels Jul 13, 2023
mayya-sharipova added a commit to mayya-sharipova/elasticsearch that referenced this pull request Jul 13, 2023
Fix for elastic#97334 where incorrect feature name was provided.

Correct more instances of synonyms_feature_flag_enabled for synonyms_api_feature_flag_enabled

Closes elastic#96641, elastic#97177
mayya-sharipova added a commit that referenced this pull request Jul 13, 2023
Fix for #97334 where incorrect feature name was provided.

Correct more instances of synonyms_feature_flag_enabled for synonyms_api_feature_flag_enabled

Closes #96641, #97177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Search Relevance/Analysis How text is split into tokens Team:Search Meta label for search team >test Issues or PRs that are addressing/adding tests v8.9.0 v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] ClientYamlTestSuiteIT test {yaml=synonyms/20_synonyms_get/Get synonyms set} failing
3 participants