Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiFocusTrap causes relayout cycles #4382

Closed
flash1293 opened this issue Dec 15, 2020 · 3 comments
Closed

EuiFocusTrap causes relayout cycles #4382

flash1293 opened this issue Dec 15, 2020 · 3 comments
Labels
⚠️ needs validation For bugs that need confirmation as to whether they're reproducible stale-issue stale-issue-closed

Comments

@flash1293
Copy link
Contributor

As discovered in elastic/kibana#85430,

if EuiFocusTrap is used, additional HTML elements are introduced and changed in some cases, triggering a layout cycle which can cause problems in other components:

  • elastic-charts components can "twitch" a little (probably because a resize observer is triggered)
  • In firefox, scrollbars flash briefly

cc @chandlerprall

@chandlerprall chandlerprall added the ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible label Dec 15, 2020
@chandlerprall
Copy link
Contributor

Marking as needing triage because the extra DOM elements are expected when enabling the focus trap. This may end up being a change in EUI (e.g. exposing a prop) or providing implementation guidance.

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

❌ We're automatically closing this issue due to lack of activity. Please comment if you feel this was done in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️ needs validation For bugs that need confirmation as to whether they're reproducible stale-issue stale-issue-closed
Projects
None yet
Development

No branches or pull requests

2 participants