Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] header cell throwing call stack errors #4484

Closed
Tracked by #85965
flash1293 opened this issue Feb 4, 2021 · 2 comments
Closed
Tracked by #85965

[EuiDataGrid] header cell throwing call stack errors #4484

flash1293 opened this issue Feb 4, 2021 · 2 comments
Labels
bug data grid ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible

Comments

@flash1293
Copy link
Contributor

In some scenarios the grid header cells seems to interact with other popovers on the same page in a way that's causing a loop of focus settings. I can't reproduce it in a codesandbox, but it's consistently happening in Lens:

  • Check out this PR [Lens] Hide column in table kibana#88680
  • Go to Lens
  • Configure data table
  • Use column header popover to hide a column
  • Open dimension editor to the right and make column visible again
  • Errors are thrown
data_grid_header_cell.js:174 Uncaught RangeError: Maximum call stack size exceeded.
    at HTMLDivElement.onFocusIn (data_grid_header_cell.js:174)
    at HTMLDivElement.onFocusIn (data_grid_header_cell.js:174)
    at HTMLDivElement.onFocusIn (data_grid_header_cell.js:174)
    at HTMLDivElement.onFocusIn (data_grid_header_cell.js:174)
    at HTMLDivElement.onFocusIn (data_grid_header_cell.js:174)
    at HTMLDivElement.onFocusIn (data_grid_header_cell.js:174)
    at HTMLDivElement.onFocusIn (data_grid_header_cell.js:174)
    at HTMLDivElement.onFocusIn (data_grid_header_cell.js:174)
    at HTMLDivElement.onFocusIn (data_grid_header_cell.js:174)
    at HTMLDivElement.onFocusIn (data_grid_header_cell.js:174)

cc @chandlerprall

@chandlerprall chandlerprall changed the title DataGrid header cell throwing call stack errors [EuiDataGrid] header cell throwing call stack errors Feb 9, 2021
@chandlerprall chandlerprall added assign:engineer bug data grid ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible labels Feb 9, 2021
@fsenart
Copy link

fsenart commented May 10, 2021

I managed to reproduce this issue in a codesandbox with the first example of the data grid in the documentation:

  1. Open the app in a new window. The bug doesn't show up when you are in the split view.
  2. Click the Account column header.
  3. Click Sort Low-High
  4. Click Columns (top left button)
  5. Toggle Location

@cee-chen
Copy link
Member

This is similar to #4384 and should have been solved by #5209. It's not yet in Kibana for live testing, but you can try testing our EUI docs site to see if you can still reproduce that issue there. Feel free to ping/re-open if so!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug data grid ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible
Projects
None yet
Development

No branches or pull requests

4 participants