Adding more props to EuiHeaderSectionItemButton, EuiFieldSearch, and EuiAccordion #2914
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing preparation for the new nav drawer
1. Added
arrowDisplay
prop to EuiAccordion for changing side or hiding completely2. Added
prepend
andappend
ability to EuiFieldSearch3. Added
notification
andnotificationColor
props to EuiHeaderSectionItemButton... to automatically add the correct positioning via CSS. Consumers used to have to supply the
<EuiNotificationBadge className="euiHeaderNotification" />
manually as a child of theEuiHeaderSectionItemButton
. Instead, I just made it an option ofEuiHeaderSectionItemButton
directly to make it simpler.This will also then deprecate the need for the class
. euiHeaderNotification
which can only be applied manually.4. Extending
div
element in EuiFlyout typeThis is so
id
can properly be passed down without complaint by TS.Checklist