Updating buttons and links to promote success
over secondary
color and fixed EuiButtonIcon colors
#4874
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4836
Added
success
andaccent
color options to EuiButtonWhile also adding a deprecation notice for the
secondary
color and promotingsuccess
instead wherever possible. All the buttons should still look the same.EuiButtonEmpty and EuiButtonIcon already only used
success
instead ofsecondary
so no changes were needed there.Fixed shaded color of some colors for EuiButtonIcon
EuiButtonIcon was using it's own Sass map for colors. Instead, it now uses the same one as EuiButton to better match each other. The contrast ratios should still be good and shouldn't affect the empty style of EuiButtonIcon.
There's minimal changes to the rendering.
Added
success
color to EuiLinkSplit button comparison
The most noticeable change now is that this array of colors is now supported by all button types and renders the same as well. Mainly you can see the lack of support for
accent
andsuccess
.['primary', 'text', 'accent', 'success', 'warning', 'danger']
Checklist
[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes