Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] Fix sorting console errors + header cell focus cleanup/refactors #5209

Merged

Commits on Sep 21, 2021

  1. Configuration menu
    Copy the full SHA
    6be8f53 View commit details
    Browse the repository at this point in the history
  2. [Fix] DRY out enableInteractives call

    Setting isCellEntered to true already makes that same call, so *should* have that same effect as long as we're consistent about changing logic via isCellEntered
    
    This also fixes elastic#4384, which was a focus-lock issue caused focusin/focusout events firing multiple times. Now with the setIsCellEntered change, focus does not fire repeatedly
    cee-chen committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    ac5e058 View commit details
    Browse the repository at this point in the history
  3. [Refactor] Remove unnecessary useEffect dependencies

    - now that we're not calling enableInteractives and focusInteractives directly but letting isCellEntered handle that for us, there's no need to include them
    
    + setIsCellEntered isn't necessary either/doesn't trigger the lint rule
    cee-chen committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    5cdd043 View commit details
    Browse the repository at this point in the history
  4. [Refactor] Improve focus unit tests

    - Separate focus tests for isFocused logic vs focusin / focusout events
    cee-chen committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    ce98765 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2021

  1. [Refactor] Move interactive fns to separate/external fns vs. useCallback

    - Removes the need for useCallback and setting the utility fns as dependencies, simplifying code
    
    - refactor for loops to forEach's
    
    - remove setIsCellEntered(true) in focusInteractables, since it now only gets called when isCellEntered is true
    cee-chen committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    541359a View commit details
    Browse the repository at this point in the history
  2. [Refactor] Combine enable and focus interactives action

    - they don't get called separately, so it makes sense to optimize the call and not make an extra tabbables call (+ reduces unnecessary branching)
    cee-chen committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    2df8152 View commit details
    Browse the repository at this point in the history
  3. [Refactor] More complete multiple interactive children unit tests

    - covers last uncovered branch in file
    
    - move to bottom of the file rather than top, since after talking to Chandler this is an edge case that only applies to control header cells
    
    + remove `data-euigrid-tab-managed` attr - tests should pass without it
    cee-chen committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    7fdef44 View commit details
    Browse the repository at this point in the history
  4. [Refactor] Misc cleanup

    - convert functions to arrow functions
    - use shorter headerNode var instead of ref
    cee-chen committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    a6f5c3b View commit details
    Browse the repository at this point in the history
  5. [Fix] Remove F2 key event

    - it's had no effect since we switched header cells to use a popover for actions
    cee-chen committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    405b1c0 View commit details
    Browse the repository at this point in the history
  6. Add changelog entry

    cee-chen committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    cdb5a42 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2021

  1. Configuration menu
    Copy the full SHA
    b80f2ad View commit details
    Browse the repository at this point in the history
  2. Update changelog

    cee-chen committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    c042b1d View commit details
    Browse the repository at this point in the history