Fix hang queue on open due to panic on atomic op #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 20, 2019 03:08
The atomic transaction counter needs to be aligned to 64bit words, so to not cause a panic on some architectures (arm or 32bit x86) Unfortunately the file lock was not released when this panic occured, making applications hang on startup. We move the atomic to the top of the file and also ensure the file lock is correctly released (using defer) if an error or panic occurs on transaction begin.
added 2 commits
January 21, 2019 11:20
|
I tested with and without the change on ARM 32bit with go1.10 and go1.11. Panic on atomic access did not occur when go-txfile is compiled with go1.11. |
urso
pushed a commit
that referenced
this pull request
Jan 24, 2019
We introduce support for testing other environments here. For now we only add ARM (32bit) support to our tests. The Travis configs are updated to cross-compile and run the testsuite on ARM, via qemu. I've been able to reproduce the panic on atomic access, which has been fixed in #31 with these tests + some false assumption in an unit test has been fixed as well. As the build and testing environment has become somewhat more complicated due to the need to cross compile and run/test via qemu, we introduce mage here. We hope for the full test suite and cross-combile/test support to be executable via Windows, Linux, and Darwin. We still target x86_64 dev environments, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The atomic transaction counter needs to be aligned to 64bit words, so to
not cause a panic on some architectures (arm or 32bit x86)
Unfortunately the file lock was not released when this panic occured,
making applications hang on startup.
We move the atomic to the top of the file and also ensure the file lock
is correctly released (using defer) if an error or panic occurs on
transaction begin.