Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aws.metrics_names_fingerprint field #11369

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Fix aws.metrics_names_fingerprint field #11369

merged 2 commits into from
Oct 10, 2024

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Oct 8, 2024 •
edited
Loading

Proposed commit message

This PR is to fix aws.metrics_names_fingerprint field: moving from metrics_names_fingerprint to aws.metrics_names_fingerprint.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@kaiyan-sheng kaiyan-sheng requested review from a team as code owners October 8, 2024 22:30
@kaiyan-sheng kaiyan-sheng self-assigned this Oct 8, 2024
@andrewkroh andrewkroh added bugfix Pull request that fixes a bug issue Integration:aws AWS Team:obs-ds-hosted-services Label for the Observability Hosted Services team [elastic/obs-ds-hosted-services] Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] labels Oct 8, 2024
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@kaiyan-sheng
Copy link
Contributor Author

Sorry all for the mistake I made in the previous PR!!

@elastic-vault-github-plugin-prod
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @kaiyan-sheng

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

agithomas
agithomas approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kcreddy
kcreddy approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as code owner

@kaiyan-sheng kaiyan-sheng merged commit 5218dff into elastic:backport-aws-2.24 Oct 10, 2024
5 checks passed
@kaiyan-sheng kaiyan-sheng deleted the fix_fingerprint_field branch October 10, 2024 14:27
@elastic-vault-github-plugin-prod
Copy link

Package aws - 2.24.3 containing this change is available at https://epr.elastic.co/search?package=aws

@kaiyan-sheng kaiyan-sheng mentioned this pull request Oct 10, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kavindu-Dodan Kavindu-Dodan Kavindu-Dodan approved these changes

@kcreddy kcreddy kcreddy approved these changes

@agithomas agithomas agithomas approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
bugfix Pull request that fixes a bug issue Integration:aws AWS Team:obs-ds-hosted-services Label for the Observability Hosted Services team [elastic/obs-ds-hosted-services] Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kaiyan-sheng @elasticmachine @Kavindu-Dodan @kcreddy @agithomas @andrewkroh