Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Asset Inventory] Organization Support #11398

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[Asset Inventory] Organization Support #11398

wants to merge 8 commits into from
+89 −38

Conversation

kubasobon
Copy link
Member

@kubasobon kubasobon commented Oct 11, 2024 •
edited
Loading

Proposed commit message

The PR:

  • Adds support for organization-wide deployment in AWS and Azure
  • Reworks deployment type selection to use a drop-down menu
  • Adds descriptions to credential fields, highlighting which ones to fill

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

Fixes https:/elastic/security-team/issues/10606

Screenshots

Screenshot 2024-10-14 at 10 05 31

Screenshot showing the new deployment type drop-down and credential field descriptions

@andrewkroh andrewkroh added enhancement New feature or request Integration:cloud_asset_inventory Cloud Asset Inventory labels Oct 11, 2024
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

@kubasobon kubasobon self-assigned this Oct 14, 2024
@kubasobon kubasobon marked this pull request as ready for review October 14, 2024 08:47
@kubasobon kubasobon requested a review from a team as a code owner October 14, 2024 08:47
@andrewkroh andrewkroh added the Team:Cloud Security Label for the Cloud Security team [elastic/cloud-security-posture] label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kubasobon kubasobon

Labels
enhancement New feature or request Integration:cloud_asset_inventory Cloud Asset Inventory Team:Cloud Security Label for the Cloud Security team [elastic/cloud-security-posture]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kubasobon @elasticmachine @andrewkroh