Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _meta information to Kubernetes fields #1289

Merged
merged 15 commits into from
Jul 6, 2021

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Jul 6, 2021

What does this PR do?

This change updates fields.yml defintions to include units and metric type information so as to enhance meta information for each collected Kubernetes fields in accordance with elastic/elasticsearch#61941. More example here.

Related issues

Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
@ChrsMark ChrsMark added the enhancement New feature or request label Jul 6, 2021
@ChrsMark ChrsMark self-assigned this Jul 6, 2021
Signed-off-by: ChrsMark <[email protected]>
@elasticmachine
Copy link

elasticmachine commented Jul 6, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1289 updated

  • Start Time: 2021-07-06T08:01:55.859+0000

  • Duration: 28 min 13 sec

  • Commit: 0a133ff

Test stats 🧪

Test Results
Failed 0
Passed 109
Skipped 0
Total 109

Trends 🧪

Image of Build Times

Image of Tests

Signed-off-by: ChrsMark <[email protected]>
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/kubernetes/changelog.yml Outdated Show resolved Hide resolved
Signed-off-by: ChrsMark <[email protected]>
@ChrsMark ChrsMark merged commit 1697d3b into elastic:master Jul 6, 2021
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add _meta information to Kubernetes fields
4 participants