Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auditd: teach kv about quoted spaces #4858

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Dec 16, 2022

What does this PR do?

Audit messages may contain spaces when the value is quoted, so let the kv processor know how to deal with this case.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:auditd Auditd Logs labels Dec 16, 2022
@efd6 efd6 self-assigned this Dec 16, 2022
Audit messages may contain spaces when the value is quoted, so let the
kv processor know how to deal with this case.
@elasticmachine
Copy link

elasticmachine commented Dec 16, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-16T20:20:40.227+0000

  • Duration: 14 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 9
Skipped 0
Total 9

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 2.251
Classes 100.0% (1/1) 💚 2.251
Methods 100.0% (15/15) 💚 8.501
Lines 97.985% (2140/2184) 👍 6.326
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review December 16, 2022 20:40
@efd6 efd6 requested a review from a team as a code owner December 16, 2022 20:40
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@efd6 efd6 merged commit f100234 into elastic:main Jan 5, 2023
@elasticmachine
Copy link

Package auditd - 3.4.2 containing this change is available at https://epr.elastic.co/search?package=auditd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:auditd Auditd Logs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants