Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apache: convert bytes_per_sec visualization to lens #530

Merged
merged 3 commits into from
Jan 14, 2021

Conversation

mtojek
Copy link
Contributor

@mtojek mtojek commented Jan 14, 2021

What does this PR do?

This PR converts single visualization (bytes per sec) to Lens.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all datasets collect metrics or logs.

Screenshots

screencapture-localhost-5601-app-dashboards-2021-01-14-12_09_02

@mtojek mtojek requested a review from skh January 14, 2021 11:09
@mtojek mtojek self-assigned this Jan 14, 2021
license: basic
description: Apache Integration
type: integration
categories:
- web
release: experimental
conditions:
kibana.version: '^7.10.0'
kibana.version: '^7.11.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lens asset will only be installed in Kibana 7.12 or higher. Can we set an unreleased version here?

Copy link
Contributor Author

@mtojek mtojek Jan 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed! I set it to 7.12.0.

@elasticmachine
Copy link

elasticmachine commented Jan 14, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #530 updated

    • Start Time: 2021-01-14T11:49:09.140+0000
  • Duration: 8 min 22 sec

  • Commit: f6fc923

Test stats 🧪

Test Results
Failed 0
Passed 11
Skipped 0
Total 11

Copy link
Contributor

@skh skh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question about the minimal Kibana version.

@mtojek mtojek merged commit 53814dd into elastic:master Jan 14, 2021
mtojek pushed a commit to mtojek/integrations that referenced this pull request Jan 18, 2021
mtojek added a commit that referenced this pull request Jan 18, 2021
* Update dependency on elastic-package

* Always run elastic-package test

* Revert "Apache: convert bytes_per_sec visualization to lens (#530)"

This reverts commit 53814dd.

* apache: fix version

* mongodb: fix mongodb-search

* system: fix kibana prefixes

* Revert "system: fix kibana prefixes"

This reverts commit 243e158.

* Revert "mongodb: fix mongodb-search"

This reverts commit 858ecb1.

* Bump up elastic-package again
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
* Apache: convert bytes_per_sec visualization to lens

* Update version to 7.12.0

* Bump up Kibana version
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
* Update dependency on elastic-package

* Always run elastic-package test

* Revert "Apache: convert bytes_per_sec visualization to lens (elastic#530)"

This reverts commit 53814dd.

* apache: fix version

* mongodb: fix mongodb-search

* system: fix kibana prefixes

* Revert "system: fix kibana prefixes"

This reverts commit 243e158.

* Revert "mongodb: fix mongodb-search"

This reverts commit 858ecb1.

* Bump up elastic-package again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants