Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[panw] Sync panw package with beats #694

Merged
merged 2 commits into from
Feb 17, 2021
Merged

[panw] Sync panw package with beats #694

merged 2 commits into from
Feb 17, 2021

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Feb 16, 2021

What does this PR do?

Syncs panw package with changes made in beats

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@marc-gr marc-gr mentioned this pull request Feb 16, 2021
Closed
89 tasks
@elasticmachine
Copy link

elasticmachine commented Feb 16, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #694 updated

  • Start Time: 2021-02-17T09:49:02.750+0000

  • Duration: 9 min 37 sec

  • Commit: 1b93a03

Test stats 🧪

Test Results
Failed 0
Passed 22
Skipped 0
Total 22

Trends 🧪

Image of Build Times

Image of Tests

P1llus
P1llus approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added some small comments, but since its not directly ECS related then maybe we should do it separately, rest is good :)

packages/panw/manifest.yml Outdated Show resolved Hide resolved
@marc-gr marc-gr merged commit 3cc1aac into elastic:master Feb 17, 2021
@marc-gr marc-gr deleted the panw-ecs-1.8 branch February 17, 2021 10:06
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@marc-gr
[panw] Sync panw package with beats (elastic#694)
7213091 
* Sync panw package with beats

* Apply suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P1llus P1llus P1llus approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marc-gr @elasticmachine @P1llus