-
Notifications
You must be signed in to change notification settings - Fork 8.2k
/
validate_actions.ts
276 lines (252 loc) · 9.56 KB
/
validate_actions.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/
import Boom from '@hapi/boom';
import { map } from 'lodash';
import { i18n } from '@kbn/i18n';
import { validateHours } from '../../routes/lib/validate_hours';
import { RawRule, RuleNotifyWhen } from '../../types';
import { UntypedNormalizedRuleType } from '../../rule_type_registry';
import { NormalizedAlertAction, NormalizedSystemAction } from '../types';
import { RulesClientContext } from '../types';
import { parseDuration } from '../../lib';
export type ValidateActionsData = Pick<RawRule, 'notifyWhen' | 'throttle' | 'schedule'> & {
actions: NormalizedAlertAction[];
systemActions?: NormalizedSystemAction[];
};
export async function validateActions(
context: RulesClientContext,
ruleType: UntypedNormalizedRuleType,
data: ValidateActionsData,
allowMissingConnectorSecrets?: boolean
): Promise<void> {
const { actions, notifyWhen, throttle, systemActions = [] } = data;
const hasRuleLevelNotifyWhen = typeof notifyWhen !== 'undefined';
const hasRuleLevelThrottle = Boolean(throttle);
if (actions.length === 0) {
return;
}
const errors = [];
const allActions = [...actions, ...systemActions];
const uniqueActions = new Set(allActions.map((action) => action.uuid));
if (uniqueActions.size < allActions.length) {
errors.push(
i18n.translate('xpack.alerting.rulesClient.validateActions.hasDuplicatedUuid', {
defaultMessage: 'Actions have duplicated UUIDs',
})
);
}
// check for actions using connectors with missing secrets
const actionsClient = await context.getActionsClient();
const actionIds = [...new Set(actions.map((action) => action.id))];
const actionResults =
(await actionsClient.getBulk({ ids: actionIds, throwIfSystemAction: false })) || [];
const actionsUsingConnectorsWithMissingSecrets = actionResults.filter(
(result) => result.isMissingSecrets
);
if (actionsUsingConnectorsWithMissingSecrets.length) {
if (allowMissingConnectorSecrets) {
context.logger.error(
`Invalid connectors with "allowMissingConnectorSecrets": ${actionsUsingConnectorsWithMissingSecrets
.map((connector) => connector.name)
.join(', ')}`
);
} else {
errors.push(
i18n.translate('xpack.alerting.rulesClient.validateActions.misconfiguredConnector', {
defaultMessage: 'Invalid connectors: {groups}',
values: {
groups: actionsUsingConnectorsWithMissingSecrets
.map((connector) => connector.name)
.join(', '),
},
})
);
}
}
// check for actions with invalid action groups
const { actionGroups: alertTypeActionGroups } = ruleType;
const usedAlertActionGroups = actions.map((action) => action.group);
const availableAlertTypeActionGroups = new Set(map(alertTypeActionGroups, 'id'));
const invalidActionGroups = usedAlertActionGroups.filter(
(group) => !availableAlertTypeActionGroups.has(group)
);
if (invalidActionGroups.length) {
errors.push(
i18n.translate('xpack.alerting.rulesClient.validateActions.invalidGroups', {
defaultMessage: 'Invalid action groups: {groups}',
values: {
groups: invalidActionGroups.join(', '),
},
})
);
}
// check for actions using frequency params if the rule has rule-level frequency params defined
if (hasRuleLevelNotifyWhen || hasRuleLevelThrottle) {
const actionsWithFrequency = actions.filter((action) => Boolean(action.frequency));
if (actionsWithFrequency.length) {
errors.push(
i18n.translate('xpack.alerting.rulesClient.validateActions.mixAndMatchFreqParams', {
defaultMessage:
'Cannot specify per-action frequency params when notify_when or throttle are defined at the rule level: {groups}',
values: {
groups: actionsWithFrequency.map((a) => a.group).join(', '),
},
})
);
}
} else {
const actionsWithoutFrequency = actions.filter((action) => !action.frequency);
if (actionsWithoutFrequency.length) {
errors.push(
i18n.translate('xpack.alerting.rulesClient.validateActions.notAllActionsWithFreq', {
defaultMessage: 'Actions missing frequency parameters: {groups}',
values: {
groups: actionsWithoutFrequency.map((a) => a.group).join(', '),
},
})
);
}
}
const scheduleInterval = parseDuration(data.schedule.interval);
const actionsWithInvalidThrottles = [];
const actionWithoutQueryAndTimeframe = [];
const actionWithInvalidTimeframe = [];
const actionsWithInvalidTimeRange = [];
const actionsWithInvalidDays = [];
const actionsWithAlertsFilterWithoutAlertsMapping = [];
for (const action of actions) {
const { alertsFilter } = action;
// check for actions throttled shorter than the rule schedule
if (
action.frequency?.notifyWhen === RuleNotifyWhen.THROTTLE &&
parseDuration(action.frequency.throttle!) < scheduleInterval
) {
actionsWithInvalidThrottles.push(action);
}
if (alertsFilter) {
// Action has alertsFilter but the ruleType does not support AAD
if (!ruleType.alerts) {
actionsWithAlertsFilterWithoutAlertsMapping.push(action);
}
// alertsFilter must have at least one of query and timeframe
if (!alertsFilter.query && !alertsFilter.timeframe) {
actionWithoutQueryAndTimeframe.push(action);
}
if (alertsFilter.timeframe) {
// hours, days and timezone fields are required
if (
!alertsFilter.timeframe.hours ||
!alertsFilter.timeframe.days ||
!alertsFilter.timeframe.timezone
) {
actionWithInvalidTimeframe.push(action);
}
if (alertsFilter.timeframe.hours) {
if (
validateHours(alertsFilter.timeframe.hours.start) ||
validateHours(alertsFilter.timeframe.hours.end)
) {
actionsWithInvalidTimeRange.push(action);
}
}
if (alertsFilter.timeframe.days) {
if (alertsFilter.timeframe.days.some((day) => ![1, 2, 3, 4, 5, 6, 7].includes(day))) {
actionsWithInvalidDays.push(action);
}
}
}
}
}
if (actionsWithInvalidThrottles.length > 0) {
errors.push(
i18n.translate('xpack.alerting.rulesClient.validateActions.actionsWithInvalidThrottles', {
defaultMessage:
'Action frequency cannot be shorter than the schedule interval of {scheduleIntervalText}: {groups}',
values: {
scheduleIntervalText: data.schedule.interval,
groups: actionsWithInvalidThrottles
.map((a) => `${a.group} (${a.frequency?.throttle})`)
.join(', '),
},
})
);
}
if (actionWithoutQueryAndTimeframe.length > 0) {
errors.push(
i18n.translate('xpack.alerting.rulesClient.validateActions.actionsWithInvalidAlertsFilter', {
defaultMessage: `Action's alertsFilter must have either "query" or "timeframe" : {uuids}`,
values: {
uuids: actionWithoutQueryAndTimeframe.map((a) => `${a.uuid}`).join(', '),
},
})
);
}
if (actionWithInvalidTimeframe.length > 0) {
errors.push(
i18n.translate('xpack.alerting.rulesClient.validateActions.actionWithInvalidTimeframe', {
defaultMessage: `Action's alertsFilter timeframe has missing fields: days, hours or timezone: {uuids}`,
values: {
uuids: actionWithInvalidTimeframe.map((a) => a.uuid).join(', '),
},
})
);
}
if (actionsWithInvalidDays.length > 0) {
errors.push(
i18n.translate('xpack.alerting.rulesClient.validateActions.actionsWithInvalidDays', {
defaultMessage: `Action's alertsFilter days has invalid values: {uuidAndDays}`,
values: {
uuidAndDays: actionsWithInvalidDays
.map((a) => `(${a.uuid}:[${a.alertsFilter!.timeframe!.days}]) `)
.join(', '),
},
})
);
}
if (actionsWithInvalidTimeRange.length > 0) {
errors.push(
i18n.translate('xpack.alerting.rulesClient.validateActions.actionsWithInvalidTimeRange', {
defaultMessage: `Action's alertsFilter time range has an invalid value: {hours}`,
values: {
hours: actionsWithInvalidTimeRange
.map(
(a) =>
`${a.alertsFilter!.timeframe!.hours.start}-${a.alertsFilter!.timeframe!.hours.end}`
)
.join(', '),
},
})
);
}
if (actionsWithAlertsFilterWithoutAlertsMapping.length > 0) {
errors.push(
i18n.translate(
'xpack.alerting.rulesClient.validateActions.actionsWithAlertsFilterWithoutSummaryGetter',
{
defaultMessage: `This ruleType ({ruleType}) can't have an action with Alerts Filter. Actions: [{uuids}]`,
values: {
uuids: actionsWithAlertsFilterWithoutAlertsMapping.map((a) => a.uuid).join(', '),
ruleType: ruleType.name,
},
}
)
);
}
// Finalize and throw any errors present
if (errors.length) {
throw Boom.badRequest(
i18n.translate('xpack.alerting.rulesClient.validateActions.errorSummary', {
defaultMessage:
'Failed to validate actions due to the following {errorNum, plural, one {error:} other {# errors:\n-}} {errorList}',
values: {
errorNum: errors.length,
errorList: errors.join('\n- '),
},
})
);
}
}