Skip to content

Commit

Permalink
[Security Solution] Fixes skipped test (#115757)
Browse files Browse the repository at this point in the history
* waits for the page to be loaded before continuing with the actions

* changes the order of the wait

* unskip data provider test

Co-authored-by: Kibana Machine <[email protected]>
  • Loading branch information
MadameSheema and kibanamachine authored Nov 3, 2021
1 parent b56979a commit 0681348
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import { addDataProvider, closeTimeline, createNewTimeline } from '../../tasks/t
import { HOSTS_URL } from '../../urls/navigation';
import { cleanKibana, scrollToBottom } from '../../tasks/common';

describe.skip('timeline data providers', () => {
describe('timeline data providers', () => {
before(() => {
cleanKibana();
loginAndWaitForPage(HOSTS_URL);
Expand Down
1 change: 1 addition & 0 deletions x-pack/plugins/security_solution/cypress/tasks/timeline.ts
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ export const addFilter = (filter: TimelineFilter): Cypress.Chainable<JQuery<HTML

export const addDataProvider = (filter: TimelineFilter): Cypress.Chainable<JQuery<HTMLElement>> => {
cy.get(TIMELINE_ADD_FIELD_BUTTON).click();
cy.get(LOADING_INDICATOR).should('not.exist');
cy.get(TIMELINE_DATA_PROVIDER_VALUE).should('have.focus'); // make sure the focus is ready before start typing

cy.get(TIMELINE_DATA_PROVIDER_FIELD)
Expand Down

0 comments on commit 0681348

Please sign in to comment.