[Reporting/Screenshots] add error for no shared items container found…

… on the page
elastic · Dec 5, 2019 · 0951fde · 0951fde
1 parent 66c7ae6
commit 0951fde
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/legacy/core_plugins/kibana/public/visualize/embeddable/visualize_embeddable.ts b/src/legacy/core_plugins/kibana/public/visualize/embeddable/visualize_embeddable.ts
@@ -313,7 +313,7 @@ export class VisualizeEmbeddable extends Embeddable<VisualizeInput, VisualizeOut
 
  div.setAttribute('data-test-subj', 'visualizationLoader');
  div.setAttribute('data-shared-item', '');
- div.setAttribute('data-shared-item-container', '');
+ div.setAttribute('data-shared-items-container', '');
  div.setAttribute('data-rendering-count', '0');
  div.setAttribute('data-render-complete', 'false');
 

diff --git a/...legacy/plugins/reporting/export_types/common/lib/screenshots/get_element_position_data.ts b/...legacy/plugins/reporting/export_types/common/lib/screenshots/get_element_position_data.ts
@@ -47,5 +47,11 @@ export const getElementPositionAndAttributes = async (
  args: [layout.selectors.screenshot, { title: 'data-title', description: 'data-description' }],
  });
 
+ if (elementsPositionAndAttributes.length === 0) {
+ throw new Error(
+ `No shared items containers were found on the page! Reporting requires an element with the '${layout.selectors.screenshot}' attributes on the page.`
+ );
+ }
+
  return elementsPositionAndAttributes;
 };